fix: XGBoostEstimator honors random_seed config#1551
Merged
thinkall merged 1 commit intoMay 21, 2026
Conversation
thinkall
approved these changes
May 21, 2026
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Seed
random_stateonXGBoostEstimator.__init__so its native-APIxgb.train(self.params, ...)path produces deterministic results across runs and honors the FLAML-internalrandom_seedconfig. Uses the same defensive pattern shipped in #1541, #1546, #1547, and #1549 — pop therandom_seedkey fromself.params, and only setrandom_statewhen the caller has not already provided one.XGBoostEstimatoris the non-sklearn-API XGBoost class — not bound to a user-facing string ingeneric_task.py, but reachable via:flaml/automl/automl.pyuses it internally for the best-config retrain path)test_regression.pydefinesMyXGB1/MyXGB2subclasses that exercise this exact pattern)This is the last XGBoost item on tracking issue #1540; the sklearn-API variants
XGBoostSklearnEstimatorandXGBoostLimitDepthEstimatorwere closed by #1549.Related issue number
Tracking issue: #1540
Pattern reference: #1549 (XGBoostSklearnEstimator), #1547 (RandomForest), #1541 (SGD), #1546 (LRL1)
Checks