fix: LRL2Classifier honors random_seed config#1552
Merged
Conversation
thinkall
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Seed
random_stateonLRL2Classifier.__init__for consistency with the rest of the audited estimator family (CatBoost, ElasticNet, LinearSVC, SGD, LRL1, RandomForest, ExtraTrees, all XGBoost variants).LRL2Classifier's default solver islbfgs, which is deterministic, so the existinglrl2reproducibility tests have always passed — but issue #1540 flagged this class as "relevant forsag/saga" solvers. Users who overridesolver="sag"orsolver="saga"via config get a stochastic solver today that doesn't honor the FLAML-internalrandom_seed. This change closes that edge case using the same defensive pattern shipped in #1541, #1546, #1547, #1549, and #1551.This is the final estimator in tracking issue #1540. With this merged, every
random_state-accepting estimator inflaml/automl/model.py(sklearn family) consistently honors the FLAMLrandom_seedconfig.Related issue number
Closes #1540
Pattern reference: #1541 (SGD), #1546 (LRL1), #1547 (RandomForest), #1549 (XGBoost-sklearn), #1551 (XGBoost-native)
Checks