Skip to content

[Shopify] Re-enable pricing tests to verify CI failure #8274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
onbuyuka wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −22
Draft

[Shopify] Re-enable pricing tests to verify CI failure #8274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c4701
[Shopify] Re-enable pricing tests to verify CI failure
onbuyuka May 21, 2026
dfd81cb
Add probes to UnitTestCalcPriceTest to diagnose CI failure
onbuyuka May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/Apps/W1/Shopify/Test/DisabledTests/ShpfyCatalogPricesTest.json
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions src/Apps/W1/Shopify/Test/DisabledTests/ShpfyProductPriceCalcTest.json
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions src/Apps/W1/Shopify/Test/Products/ShpfyProductPriceCalcTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ codeunit 139605 "Shpfy Product Price Calc. Test"
InitializeTest: Codeunit "Shpfy Initialize Test";
ProductInitTest: Codeunit "Shpfy Product Init Test";
ProductPriceCalculation: Codeunit "Shpfy Product Price Calc.";
PriceCalcMgt: Codeunit "Price Calculation Mgt.";
InitUnitCost: Decimal;
InitPrice: Decimal;
InitDiscountPerc: Decimal;
Expand All @@ -45,6 +46,8 @@ codeunit 139605 "Shpfy Product Price Calc. Test"
begin
// [INIT] Initialization startup data.
LibraryPriceCalculation.DisableExtendedPriceCalculation();
// PROBE 1: confirm what IsExtendedPriceCalculationEnabled returns in this env
LibraryAssert.AreEqual(false, PriceCalcMgt.IsExtendedPriceCalculationEnabled(), 'PROBE_1_IsExtendedShouldBeFalseAfterDisable');
Shop := InitializeTest.CreateShop();
Shop."Allow Line Disc." := false;
Shop.Modify();
Expand Down Expand Up @@ -80,6 +83,10 @@ codeunit 139605 "Shpfy Product Price Calc. Test"
ProductPriceCalculation.CalcPrice(Item, '', '', UnitCost, Price, ComparePrice);
// [THEN] InitUnitCost = UnitCost
LibraryAssert.AreEqual(InitUnitCost, UnitCost, 'Unit Cost');
// PROBE 2: confirm what IsExtended returns AFTER setting up discount group
LibraryAssert.AreEqual(false, PriceCalcMgt.IsExtendedPriceCalculationEnabled(), 'PROBE_2_IsExtendedShouldStillBeFalse');
// PROBE 3: dump Price/ComparePrice values into the failure message so we can see them
LibraryAssert.AreNotEqual(InitPrice, Price, StrSubstNo('PROBE_3_DiscountApplied? Price=%1 InitPrice=%2 ComparePrice=%3 InitDiscountPerc=%4', Price, InitPrice, ComparePrice, InitDiscountPerc));
// [THEN] InitPrice = ComparePrice. ComparePrice is the price without the discount.
LibraryAssert.AreEqual(InitPrice, ComparePrice, 'Compare Price');
// [THEN] InitPrice - InitDiscountPerc = Price
Expand Down
Loading