[Shopify] Re-enable pricing tests to verify CI failure#8274
Draft
onbuyuka wants to merge 2 commits into
Draft
Conversation
Fixes AB#621557 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PROBE_1: IsExtendedPriceCalculationEnabled() should be false after Disable PROBE_2: IsExtendedPriceCalculationEnabled() should still be false later PROBE_3: Discount should be applied (Price != InitPrice) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables the 3 Shopify pricing tests disabled in #6616 to verify whether they still fail in CI.
Local results (BC 29.0.50580.0 dev build): all 3 pass.
Suspected CI failure cause is that the legacy V15 pricing path (which these tests rely on via
DisableExtendedPriceCalculation()+ legacySales Price/Sales Line Discounttables) is no longer reachable underCLEAN27in the shipped BaseApp, due to NAV 6727d51f3c45 (Revert feature activation change for Pricing, PR 238622, Feb 2). This draft is to empirically confirm whether the bcinsider/Sandbox/29.0.50533.0 artifact used by CI actually hasCLEAN27defined.If the tests still fail, the production code in
PriceCalculationMgt.FindSetuphas a latent contract regression for any tenant withSalesPricesfeature off (and that warrants a NAV-side fix). If they pass, the original disable can be reverted permanently.Fixes AB#621557