[BC Idea]: Add 'Remaining amount' field to G/L entries for partially reviewed entries

[Bertverbeek4PS]

Summary

This will add the feature of remaining amount to review entries

Work Item(s)

Fixes #28318

Fixes AB#558313

[Bertverbeek4PS]

@AndersLarsenMicrosoft would like your opinion on this one.
This is bigger then I thought
Need to add test automation, dataconversion etc. But do you also want to have a page were you can zoom into the review log

@NicoleVvdH FYI

[AndersLarsenMicrosoft]

Looks ok

[AndersLarsenMicrosoft]

will you add some test?

[Bertverbeek4PS]

will you add some test?

Yes I will indeed add some test. Hopefully today or tomorrow

[github-actions]

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

[AndersLarsenMicrosoft]

all good

[JesperSchulz]

Looks good to me! I've added a few small comments, but I've taken care of them in the internal PR.

[JesperSchulz]

Internal PR is getting merged. I will force merge this PR. It will get reverted with the next sync, as the merge PR internally isn't done yet. But the code will reappear with the sync after that 🙂

[NicoleVvdH]

Wow, a lot has happened these last few weeks!
So what are now the next steps, ETA for release?
And is there a preview available anywhere?

Again, thank you all for addressing this issue!

[Bertverbeek4PS]

I think it will be in BC27.
And not done it yet. But if you create a next major docker container it will be there.

[NicoleVvdH]

I was checking a BC27 environment, but couldn't yet find the changes.
@JesperSchulz can you confirm the functionality will be available with BC27? Or BC27.1?

[Bertverbeek4PS]

@NicoleVvdH in mine US sandbox (preview 27) in the purchase setup:

[NicoleVvdH]

@Bertverbeek4PS But what would this setup have to do with reviewing G/L entries?

[Bertverbeek4PS]

@NicoleVvdH sorry totally got the wrong PR.
But this feature is also added:

[NicoleVvdH]

@Bertverbeek4PS Ah yes I see it now.
But... maybe I am misunderstanding the functionality:
When I review the entries, the remaining amount doesn't change. Shouldn't the remaining amount be updated when entries are reviewed? Or am I forgetting some setup?

[Bertverbeek4PS]

@NicoleVvdH
You need to select "set selected as reviewed"
Then you get it:

[NicoleVvdH]

@Bertverbeek4PS
I did, hence the values in the 'Reviewed By' & 'Reviewed Date' columns. But that doesn't do anything with the 'Remaining Amount' column...
And I see the same in your picture: the 'Reviewed By&Date' columns are filled, but the 'Remaining Amount' column is not 0,00.
That doesn't seem OK to me.

[Bertverbeek4PS]

@NicoleVvdH I did a partial review of 100. And tehre you see then that the remeaning amount is 9.850 instead of 9.950.

[NicoleVvdH]

@Bertverbeek4PS Ah I see the difference now. On first glance the amounts looked the same.
However, for whatever reason they don't change in my environment... Not on a partial review and not on a full review.
I will try and check in another environment

[NicoleVvdH]

@Bertverbeek4PS I finally see what I did wrong... I didn't fill in the 'Amount to review' field, and then the remaining amount doesn't change.
But it feels a bit unlogical to have to fill that field manually, when I am selecting 2 entries: to apply/review to each other.
Maybe in a next version/release can we add that the 'Amount to review' is automatically filled?

Also, when I have reviewed an entry, in the review page the entry will be set to 'Reviewed' = YES and the 'Remaining Amount' is 0.
But that is not what is shown in the G/L entries page itself?

I feel like some big steps are made, but we're not there yet :)
How should we follow-up on this?
@JesperSchulz any ideas on how to further improve?

[Bertverbeek4PS]

@Bertverbeek4PS I finally see what I did wrong... I didn't fill in the 'Amount to review' field, and then the remaining amount doesn't change. But it feels a bit unlogical to have to fill that field manually, when I am selecting 2 entries: to apply/review to each other. Maybe in a next version/release can we add that the 'Amount to review' is automatically filled?

Also, when I have reviewed an entry, in the review page the entry will be set to 'Reviewed' = YES and the 'Remaining Amount' is 0. But that is not what is shown in the G/L entries page itself?

I feel like some big steps are made, but we're not there yet :) How should we follow-up on this? @JesperSchulz any ideas on how to further improve?

Well on both is something to say @NicoleVvdH . Filling the amount or maybe leave it empty as it is today.
I'm fine with both 😄 .
I can create another pull request for that. No problem.

But for the fields in side the G/L entry that is part from the old dutch functionality,
Other localizations don't have those fields.
And are also not part of the extention review G/L entries.
So that is way those fields are not affected by this new function.

[NicoleVvdH]

@Bertverbeek4PS
I believe if we want the functionality to resemble the old "Applying G/L entries" functionality, the 'Amount to review' should be filled based on what entries have been selected. So I would 'vote' for a pulll request on that part :)

And the Idea in the first place was to add a 'Remaining Amount' field (it is even in the description of this issue ;) )
So if it is now a localized field, it should be converted to or created as a new field, right?

[Bertverbeek4PS]

@NicoleVvdH I have created #29317 for filling the field "Amount to Review".

Indeed but in the page there is the field "Remaining amount" This field is not in the table because calculations etc.

[NicoleVvdH]

@Bertverbeek4PS If the "Remaining Amount" field is now a calculated field on the "Review G/L entries" page, it would be nice it it were also added as a calculated field on the "G/L entries" page. That is where users will look to see what entries have a remaining amount.
The 'old' NL localization "Remaining Amount" field that is still in the table and doesn't change by reviewing the entries, will eventually be removed but now causes confusion I believe.

(PS just to add: I really appreciate the discussion and collaboration 🙂)

[Bertverbeek4PS]

@NicoleVvdH very sorry for my late reply. But with Directions and all the husle around it anad everything is setle down I got time.
PR for the automatically filles field is here:
#29468

I have added your idea also on this issue:
#29469