Skip to content

Conversation

@dnicolodi
Copy link
Member

No description provided.

@dnicolodi dnicolodi force-pushed the ci-releases-trusted-publishing branch from d182e09 to 721d71e Compare November 1, 2025 19:52
@rgommers
Copy link
Contributor

rgommers commented Nov 1, 2025

I just finished implementing this, as I said I would a few days ago in #710 (comment)

@rgommers
Copy link
Contributor

rgommers commented Nov 1, 2025

It's essentially the same: main...rgommers:meson-python:use-trusted-publishing. Differences:

  • Runs on PRs to ensure it stays in decent shape (it's low-risk, but still)
  • It uses setup-python rather than whatever the python is on the GHA runner image

Feel free to merge them. Yours has a nicer pattern for push: tags:.

@rgommers rgommers added the CI Continuous Integration label Nov 1, 2025
@rgommers rgommers added this to the v0.19.0 milestone Nov 1, 2025
@dnicolodi
Copy link
Member Author

Sorry. This is basically copy and paste from another project of mines thus it took very little to put together.

I agree that running on PRs is a good idea. I'd look at the other differences.

@rgommers
Copy link
Contributor

rgommers commented Nov 1, 2025

No worries. The only other thing I suggest is to name the deployment env pypi rather than upload for clarity. We may also want to auto-create a GitHub release at some point (although I'm less enthusiastic about the third-party actions that can do that).

@dnicolodi dnicolodi force-pushed the ci-releases-trusted-publishing branch 4 times, most recently from 3dca6bf to 13e3c62 Compare November 1, 2025 20:43
@dnicolodi dnicolodi force-pushed the ci-releases-trusted-publishing branch from 13e3c62 to 331f4b6 Compare November 1, 2025 20:51
runs-on: ubuntu-latest
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
environment:
name: pipy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be pypi.

@rgommers
Copy link
Contributor

@dnicolodi I missed your last push, you did address my one remaining comment. Shall we merge this (after fixing the typo) and wire it up before doing the 0.19.0 release?

@dnicolodi
Copy link
Member Author

I think the typo is inconsequential but I'll fix it later today. The 0.19.0 release may be a good opportunity to test this before we forget about it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants