-
Notifications
You must be signed in to change notification settings - Fork 39
Avoid segmentation fault errors during CI tests #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There appear to be a couple of unexpected linting failures, which I'll also attempt to resolve in this PR.
|
|
Coverage tests failed due to the segmentation fault ( |
….Series is not defined)
…rror (Series[Any] not callable)
|
Despite excluding the
In that case, the last successful test was:
This seems to suggest that the segfault might also occur (albeit less frequently) during the I'll try excluding the |
|
Noting unexpected test failure, which I guess is random and unrelated:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
+ Coverage 92.01% 92.05% +0.03%
==========================================
Files 49 49
Lines 5175 5175
==========================================
+ Hits 4762 4764 +2
+ Misses 413 411 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jonbrenas @tristanpwdennis @ahernank After fixing the linting errors in This seems to confirm that the segfault issue is limited to the |
|
Noting another unexpected test failure, which I guess is random and unrelated:
|
|
Confusingly, the same tests for the |
|
Currently failing to reproduce the segfault failure here, even though it was reproduced a couple of days ago. I'll try re-running the CI tests on the master branch. |
|
The re-running of code tests on master completed successfully: But the code tests with code coverage raised the segfault error: This seems to confirm that this segfault error is rather sporadic. Also, there was an unexpected error during the latest Notebook tests on the master branch: |
…pt case_adir1_sim
|
Noting |
Re: issue #835