Skip to content

Conversation

@tristanpwdennis
Copy link
Collaborator

Hi guys

I've been working on plugging the API into the Anopheles dirus data that has been sitting on GCP for a while now. So far a lot of the API runs fine. There are some modifications I've had to make to the API - mainly to do with commenting out features and bits that the data doesn't have yet that break the API or the metadata when you try and instantiate it.

Will prob be a little time before this is ready to merge into the rest of the API and producing a public-ready release. I'm still working out what runs and what doesn't run yet, but this is a rough first draft if anyone is interested in having a look or taking it for a spin.

Will request a review in due course!

@ahernank
Copy link
Collaborator

Thanks @tristanpwdennis! @leehart would be the best person to take a look at this one first, as he has been thinking about the overall codebase and integrations recently.

I've also added you to the repo as a contributor, as PRs from forks don't allow for test runs. You should now be able to open a new PR directly to the repo so you don't have this issue.

@leehart
Copy link
Collaborator

leehart commented Jun 16, 2025

Hi @tristanpwdennis. I'm just going to convert this PR to a draft until it's ready for review, even though we'll probably want to close this when you set up a non-fork equivalent.

Just to clarity, we'll need the existing code in anoph/sample_metadata.py to support the existing functionality for ag3.py and af1.py. Some re-engineering on a higher level might be required to allow some expected common features to remain un-implemented for new classes (inheriting AnophelesDataResource) in the appropriate way.

We're currently in the process of adding support for An. stephensi data, which will probably be via as1.py in a similar way:

@leehart leehart marked this pull request as draft June 16, 2025 16:05
@leehart leehart marked this pull request as draft June 16, 2025 16:05
@tristanpwdennis tristanpwdennis mentioned this pull request Jun 17, 2025
@tristanpwdennis
Copy link
Collaborator Author

Moved to #795

@leehart
Copy link
Collaborator

leehart commented Oct 16, 2025

Re: issue #797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants