Skip to content

Tighten cache type annotations #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fr3r34tgf5r4ef wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tighten cache type annotations #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions malariagen_data/anoph/snp_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,12 @@ def __init__(
self._default_site_mask = default_site_mask

# Set up caches.
# TODO review type annotations here, maybe can tighten
self._cache_snp_sites = None
self._cache_snp_genotypes: Dict = dict()
self._cache_site_filters: Dict = dict()
self._cache_site_annotations = None
self._cache_locate_site_class: Dict = dict()


self._cache_snp_sites: Optional[Any] = None
self._cache_snp_genotypes: Dict[str, Any] = dict()
self._cache_site_filters: Dict[str, Any] = dict()
self._cache_site_annotations: Optional[Any] = None
self._cache_locate_site_class: Dict[str, Any] = dict()
# Create the SNP-calls cache as a per-instance lru_cache wrapping the
# bound method. Storing it on the instance (rather than using a
# class-level @lru_cache decorator) means:
Expand Down