Improve error handling in _parse_metadata_paths#1178
Open
vshnvii wants to merge 1 commit intomalariagen:masterfrom
Open
Improve error handling in _parse_metadata_paths#1178vshnvii wants to merge 1 commit intomalariagen:masterfrom
vshnvii wants to merge 1 commit intomalariagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves error handling in
_parse_metadata_pathsby providing clearer and more informative error messages when metadata loading fails.Motivation
While exploring the code, I noticed that exceptions returned during file loading are passed directly to parsing functions. This can lead to unclear or indirect errors, making debugging harder.
Changes
RuntimeErrorwith:Example
Instead of a generic failure, users will now see:
Failed to load metadata for sample set 'XYZ' at path '...'. Original error: ...
Notes
This improves debuggability and user experience without changing the existing API behavior.