minor code refactor in genome_sequence funcion#1172
Open
Kaustubh2k5 wants to merge 2 commits intomalariagen:masterfrom
Open
minor code refactor in genome_sequence funcion#1172Kaustubh2k5 wants to merge 2 commits intomalariagen:masterfrom
Kaustubh2k5 wants to merge 2 commits intomalariagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
genome_sequenceregion normalisationi found this part of the code to be unnecessarily complex (did not see a reason as to why) so i simplified some of the checks without changing any of the code behaviour.
Changes
type()check withisinstance(region, (list, tuple))tuple("*")wildcard comparison with a directregion == "*"checksequenceslistarrayssequencesfor clarityNonebehaviour explicit (returns all contigs)Before
After
Issues targeted:
#1171