refactor: tighten type annotations for cache variables in sample_metadata.py#1157
Open
faizavk wants to merge 4 commits intomalariagen:masterfrom
Open
refactor: tighten type annotations for cache variables in sample_metadata.py#1157faizavk wants to merge 4 commits intomalariagen:masterfrom
faizavk wants to merge 4 commits intomalariagen:masterfrom
Conversation
Author
|
I noticed _cache_cohorts on line 87 is also a bare Dict in the same block. I've updated the PR to include this annotation as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens the type annotations for two cache variables in AnophelesSampleMetadata.init. _cache_sample_metadata and _cache_cohort_geometries were previously typed as bare Dict with no key or value types. They have been updated to Dict[Tuple[str, ...], pd.DataFrame] and Dict[Tuple[str, str], Dict[str, Any]] respectively, based on the actual types stored and retrieved in the codebase. This follows the same pattern as PR #1129.