[kmac] Specify and implement a dynamic app interface extension#30141
Draft
etterli wants to merge 2 commits into
Draft
[kmac] Specify and implement a dynamic app interface extension#30141etterli wants to merge 2 commits into
etterli wants to merge 2 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the current KMAC application interface so it supports changing the hashing configuration at runtime. The new interface mode is called 'dynamic'. The extension keeps full compatibility with the existing interface behavior, hereinafter referred to as 'static'.
The new interface behavior is described / specified in the
hw/ip/kmac/doc/theory_of_operation.md.The diagrams in the documentation are best viewed by building the documentation locally using:
util/site/build-docs.sh serve(or if using VS code install the wavedrom and a mermaid extensions).
Note, this PR should not yet be merged, as the changes also directly break the
keymgr,keymgr_dpe,rom_ctrl, andlc_ctrlIPs. The reason is that the typesapp_req_tandapp_rsp_tare modified. This PR would also break the DV ofkmacand the related IPs.I will push commits resolving these problems but for now I think it would make sense to start reviewing the specification and core implementation of the interface.