[chip,dv] Tidy-ups in chip_sw_small_escalation_resets_vseq#30101
Open
rswarbrick wants to merge 4 commits into
Open
[chip,dv] Tidy-ups in chip_sw_small_escalation_resets_vseq#30101rswarbrick wants to merge 4 commits into
rswarbrick wants to merge 4 commits into
Conversation
rswarbrick
added
Component:DV
These plusargs have never actually been used (which you can check with "git log -p -Sinject_fatal_error_for_sec_cm" and "git log -p -Sinject_fatal_error_for_ips"). Remove the code. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This macro was added in 274d0e0 and has only ever been used in the vseq that prompted it. The DELIMITER_ argument has always been "," and the CHECK_EXISTS_ argument has never been provided. Get rid of the macro and replace it with a function. Even copied between Earlgrey and Darjeeling, the result is still shorter. It also makes it more obvious which argument is a string (the name of the plusarg) and which argument is the destination queue. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
The second plusarg was added in commit bd1a4f9, and is a little strange because it does exactly the same thing as +avoid_inject_fatal_error_for_ips, which already existed. Merge the two. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This plusarg was added (but not used) in commit f96125c. Since it has never been used, let's drop it. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
chip-sw-all-escalation-resets-tidyup
branch
from
3994033 to
4892987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these improvements changes behaviour, but they all get rid of some unused "DV structure".