feat(website): Add success toast notification when releasing sequences

[theosanderson]

Description

Added a success toast notification that displays when sequences are successfully released through the approve processed data operation.

🚀 Preview: https://claude-add-release-toast.loculus.org

[claude]

Claude finished @theosanderson's task in 2m 11s —— View job

---

Code Review

• Read changed files
• Analyze code
• Post review

---

The implementation is clean and the loading → success/error toast pattern is a nice UX improvement. A few issues below.

context not safely typed in onSuccess

On line 76, context as { toastId: string | number } assumes context is never undefined. The onError handler (line 88) correctly uses { toastId: string | number } | undefined, but onSuccess doesn't — if context were somehow absent this would throw. These should be consistent; the onSuccess handler should do the same defensive check. Fix this →

Unreachable else branch

Lines 96–98 (openErrorFeedback(...) in the else) can never execute — onMutate always runs before onError in react-query, so context will always contain toastId. The else branch is dead code. Fix this →

Batch detection edge case

data.length > 1 (line 77) means releasing exactly 1 sequence from a batch selection shows the single-item message. This is arguably fine, but data.length > 0 for single and >= 1 for "any" might be worth reconsidering. More importantly, the batch toast sets autoClose: false — this means it never dismisses unless the user clicks it. Worth confirming this is intended UX.

Test coverage

The PR checklist marks tests as covered, but no new test files are included. The existing review-page.spec.ts integration test exercises approveAll() but doesn't assert the toast appears. Consider adding a toast assertion there, or unchecking that checklist item.

[maverbiest]

Very nice!

One thing I noticed on the preview is that the 🎉 All sequences have been released successfully! toast doesn't go away unless I do a hard reload of the page, and it blocks some buttons in the UI. Shouldn't toasts close when you click them? (at least, that's what I'm used to from a user perspective)

[tombch]

I just realised I did not actually click send on my review - but I have the same comment as Max 😆

[maverbiest]

Looks great!