Merged
Conversation
18c97e3 to
95db956
Compare
Contributor
|
Claude finished @maverbiest's task in 3m 5s —— View job Code Review
Good addition overall — clean FastAPI structure, well-documented, and the test setup with dependency injection is solid. A few things worth addressing before merge: Bug
Code quality
Security
Performance
Kubernetes
Testing
|
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
reviewed
Mar 25, 2026
anna-parker
approved these changes
Mar 25, 2026
Contributor
anna-parker
left a comment
There was a problem hiding this comment.
Lgtm - I would probably still remove the dbSha256 to reduce the config size but not blocking :-)
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a taxonomy service that exposes NCBI taxonomy data via a REST API.
We will be able to use this for scientific host name validation in prepro and other taxonomy-related functionality.
API
GET /GET /taxa?scientific_name=<string>scientific_namequery parameter.GET /taxa/{tax_id}?find_common_name=<boolean>Manual testing:
On a preview
I started a preview off this branch, which came up healthy. I could see the
taxonomy-servicecome up on argoCD.I could query the service from inside the cluster using
kubectl, e.g., from a preprocessing pod:The request was also logged in the argoCD pod of the taxonomy-service:
INFO: 10.42.1.116:34544 - "GET /taxa?name=Aedes+aegypti HTTP/1.1" 200 OKLocally (thank you Claude)
kubectl patch deployment loculus-taxonomy-service -p '{"spec":{"template":{"spec":{"containers":[{"name":"taxonomy-service","imagePullPolicy":"Never"}]}}}}' kubectl delete pod -l app=loculus,component=loculus-taxonomy-serviceAfter these steps, I can:
➜ loculus git:(taxonomy-service) curl http://localhost:5000/ {"message":"Taxonomy service is running"}From within the cluster, the service is available at
http://loculus-taxonomy-service:5000/taxa:PR Checklist
🚀 Preview: https://taxonomy-service.loculus.org