Open
Conversation
rneher
force-pushed
the
website/fieldSelectorModal
branch
from
9147322 to
663d2ca
Compare
anna-parker
reviewed
Feb 16, 2026
| acc[header].push(field); | ||
| return acc; | ||
| }, {}); | ||
| console.log('fieldsByHeader', fieldsByHeader); |
Contributor
There was a problem hiding this comment.
We definitely should improve the ordering - I think we could reuse the sequenceDetailsOrder for the search, column selector and metadata fields selector though to have consistent ordering throughout
Contributor
There was a problem hiding this comment.
I started doing this in #5985 - will let you know when it is done!
Contributor
Author
There was a problem hiding this comment.
I had found your PR after I did this. Since we already have the sortOrder in the config, that is where it should be, I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort the fields in fieldSelector and columnMapping in more sensible way.
🚀 Preview: Add
previewlabel to enable