Improve OTel tracing for analytics and aws cli#231
Open
carole-lavillonniere wants to merge 1 commit intomainfrom
Open
Improve OTel tracing for analytics and aws cli#231carole-lavillonniere wants to merge 1 commit intomainfrom
carole-lavillonniere wants to merge 1 commit intomainfrom
Conversation
cb34688 to
e92d1f8
Compare
Contributor
|
Question: there is a difference in time for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Traces emitted under
LSTK_OTEL=1were not fine-grained enough around thelstk awswrapper. Investigation revealed several blind spots: the telemetry call, the Docker daemon-ID lookup used to derivemachine_id, and theawsCLI subprocess itself were either uninstrumented or producing orphaned/dropped spans.Changes
otelhttp.NewTransportLoadOrCreateMachineIDawscli.Execin a span (aws cli)cmd/root.go:Executesotel.Close()runs before the tracer-provider shutdown (otherwise the analytics POST span is created on a noop tracer after shutdown and never reaches the exporter)GetEnvironment(ctx)) so the Dockerinfo/_pingspans are parented to the active command span instead of orphaned at process init.toward DRG-809
Result of running
lstk aws sts get-caller-identity: