Skip to content

fix(twirp): URL path construction causing bad_route errors #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
burnmandont wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(twirp): URL path construction causing bad_route errors #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions livekit-api/src/services/twirp_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,8 @@ impl TwirpClient {
) -> TwirpResult<R> {
let mut url = url::Url::parse(&self.host)?;

if let Ok(mut segs) = url.path_segments_mut() {
segs.push(&format!("{}/{}.{}/{}", self.prefix, self.pkg, service, method));
}
// Fix: Use set_path instead of path_segments_mut().push() to avoid URL-encoding slashes
url.set_path(&format!("{}/{}.{}/{}", self.prefix, self.pkg, service, method));

headers.insert(CONTENT_TYPE, HeaderValue::from_static("application/protobuf"));

Expand Down