fix(twirp): URL path construction causing bad_route errors #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
twirp_client.rsline 107,url.path_segments_mut().push()was used to construct the Twirp endpoint URL. This method URL-encodes forward slashes as%2F, resulting in malformed URLs that LiveKit server couldn't parse.Before:
Expected:
http://localhost:7890/twirp/livekit.RoomService/CreateRoomActual:
http://localhost:7890/%2Ftwirp%2Flivekit.RoomService%2FCreateRoomPR Solution:
Use
url.set_path()instead, which correctly sets the entire path without encoding forward slashes.