Skip to content

Bugfix to support unbound keyslot when sealing key #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedafidev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix to support unbound keyslot when sealing key #2046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92ee9ce
Skip non numeric keyslots
thedafidev Jan 24, 2026
05009fc
Change the LUKSv2 regex and sed_command to ignore unbound keyslots
thedafidev Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions initrd/bin/kexec-seal-key
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ find_drk_key_slot() {
local keyslot

for keyslot in "${luks_used_keyslots[@]}"; do
# Keyslots are expected to be numeric, skip non-numeric keyslots for robustness
if ! [[ "$keyslot" =~ ^[0-9]+$ ]]; then
DEBUG "Skipping non-numeric keyslot: $keyslot"
continue
fi
if [ -z "$temp_drk_key_slot" ]; then
DEBUG "Testing LUKS key slot $keyslot against $DISK_RECOVERY_KEY_FILE for Disk Recovery Key slot..."
if DO_WITH_DEBUG cryptsetup open --test-passphrase --key-slot "$keyslot" --key-file "$DISK_RECOVERY_KEY_FILE" "$dev"; then
Expand Down Expand Up @@ -138,8 +143,8 @@ for dev in $key_devices; do
if [ "$luks_version" == "2" ]; then
# LUKSv2 last key slot is 31
duk_keyslot=31
regex="^\s+([0-9]+):\s*luks2"
sed_command="s/^\s\+\([0-9]\+\):\s*luks2/\1/g"
regex="^\s+([0-9]+):\s*luks2$"
sed_command="s/^\s\+\([0-9]\+\):\s*luks2$/\1/g"
previous_luks_header_version=2
DEBUG "$dev: LUKSv2 device detected"
elif [ "$luks_version" == "1" ]; then
Expand Down Expand Up @@ -170,6 +175,11 @@ for dev in $key_devices; do

# If the key slot is not the expected DUK or DRK key slot, we will ask the user to confirm the wipe
for keyslot in "${luks_used_keyslots[@]}"; do
# Keyslots are expected to be numeric, skip non-numeric keyslots for robustness
if ! [[ "$keyslot" =~ ^[0-9]+$ ]]; then
DEBUG "Skipping non-numeric keyslot: $keyslot"
continue
fi
if [ "$keyslot" != "$drk_key_slot" ]; then
#set wipe_desired to no by default
wipe_desired="no"
Expand Down