boards, module and Makefile: drop iotools

[macpijan]

As discussed in: #1704
there is no need to include iotools module for nitropads.

[JonathonHall-Purism]

@macpijan This was the only use of iotools right? If so please remove modules/iotools and the bits from Makefile

[macpijan]

If so please remove modules/iotools and the bits from Makefile

I removed it at first.

@tlaurion Said it was not the only user of it, now I am confused: #1704 (comment)

Perhaps you meant I should remove it from these as well?

./qemu-coreboot-fbwhiptail-tpm1-hotp/qemu-coreboot-fbwhiptail-tpm1-hotp.config:#CONFIG_IOTOOLS=y
./qemu-coreboot-fbwhiptail-tpm1/qemu-coreboot-fbwhiptail-tpm1.config:CONFIG_IOTOOLS=y
./qemu-coreboot-fbwhiptail-tpm2-hotp/qemu-coreboot-fbwhiptail-tpm2-hotp.config:CONFIG_IOTOOLS=y
./qemu-coreboot-fbwhiptail-tpm2/qemu-coreboot-fbwhiptail-tpm2.config:CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm1-hotp/qemu-coreboot-whiptail-tpm1-hotp.config:CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm1/qemu-coreboot-whiptail-tpm1.config:CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm2-hotp/qemu-coreboot-whiptail-tpm2-hotp.config:#CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm2/qemu-coreboot-whiptail-tpm2.config:#CONFIG_IOTOOLS=y
./x230-hotp-maximized/x230-hotp-maximized.config:#CONFIG_IOTOOLS=y

?

[tlaurion]

@JonathonHall-Purism yes.

no more iotools calls in codebase outside of initrd/bin/nitropad-shutdown.sh which vanished under #1704

[tlaurion]

If so please remove modules/iotools and the bits from Makefile

I removed it at first.

@tlaurion Said it was not the only user of it, now I am confused: #1704 (comment)

Perhaps you meant I should remove it from these as well?

./qemu-coreboot-fbwhiptail-tpm1-hotp/qemu-coreboot-fbwhiptail-tpm1-hotp.config:#CONFIG_IOTOOLS=y
./qemu-coreboot-fbwhiptail-tpm1/qemu-coreboot-fbwhiptail-tpm1.config:CONFIG_IOTOOLS=y
./qemu-coreboot-fbwhiptail-tpm2-hotp/qemu-coreboot-fbwhiptail-tpm2-hotp.config:CONFIG_IOTOOLS=y
./qemu-coreboot-fbwhiptail-tpm2/qemu-coreboot-fbwhiptail-tpm2.config:CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm1-hotp/qemu-coreboot-whiptail-tpm1-hotp.config:CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm1/qemu-coreboot-whiptail-tpm1.config:CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm2-hotp/qemu-coreboot-whiptail-tpm2-hotp.config:#CONFIG_IOTOOLS=y
./qemu-coreboot-whiptail-tpm2/qemu-coreboot-whiptail-tpm2.config:#CONFIG_IOTOOLS=y
./x230-hotp-maximized/x230-hotp-maximized.config:#CONFIG_IOTOOLS=y

?

Sorry. What I meant is that boards, mostly testing boards (qemu) where referencing it (including it for testing purposes) while if the modules vanishes and boards still referring to it, they would break at builds.

TLDR: all references to IOTOOLS need to disappear, including Makefile conditional inclusion. Makes sense?

• Remove all references, comments (#CONFIG_IOTOOLS=y) or board definitions (CONFIG_IOTOOLS=y) and inclusion (Makefile).

[tlaurion]

Renamed PR to match goal, will close #1706

[JonathonHall-Purism]

LGTM, thanks 🙇

[tlaurion]

@macpijan thanks for contributing upstream! Much appreciated!!!!!! Merging