ACLP Alerting go SDK #824

srbhaakamai · 2025-09-15T13:55:50Z

📝 Description

Provide go SDK support to ACLP clients to perform CRUD operations for Alerts.

✔️ How to Test

How do I run the relevant unit/integration tests?

Prerequisites
Go 1.19+ installed
Valid Linode API token with monitor permissions
Export LINODE_TOKEN environment variable for integration tests

Run all monitor alert definition unit tests:
UNIT TEST:
go test ./test/unit -run ".MonitorAlertDefinition." -v

Expected Output:

✅ TestCreateMonitorAlertDefinition
✅ TestCreateMonitorAlertDefinitionWithIdempotency
✅ TestGetMonitorAlertDefinition
✅ TestListMonitorAlertDefinitions
✅ TestUpdateMonitorAlertDefinition
✅ TestUpdateMonitorAlertDefinition_LabelOnly
✅ TestDeleteMonitorAlertDefinition

INTEGRATION TEST:
export LINODE_TOKEN="your-linode-api-token"
go test ./test/integration -run "TestMonitorAlertDefinition_smoke" -v

Test Coverage:

List Operations: Validates fetching existing alert definitions
Channel Discovery: Finds available alert channels for testing
Create: Tests complex alert definition creation with:
TriggerConditions (evaluation periods, polling intervals)
RuleCriteria with Rules (metrics, operators, thresholds)
DimensionFilters (node type filtering)
Update: Tests label-only updates with proper timing
Delete: Tests cleanup with exponential backoff retry logic
Expected Duration: ~102 seconds (includes API timing requirements)

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

Copilot

Pull Request Overview

This PR introduces ACLP (Alerting Linode Platform) SDK functionality to the linodego client library, adding support for monitor alert definitions and channels. The implementation includes API client methods, data structures, and comprehensive test coverage.

Adds monitor alert definitions CRUD operations with support for v4beta API endpoints
Implements monitor channels functionality for alert notification management
Provides comprehensive unit and integration test coverage for all new functionality

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
monitor_alert_definitions.go	Core implementation of alert definitions API client methods and data structures
monitor_channels.go	Monitor channels API client methods and channel management functionality
request_helpers.go	New helper function for v4beta API endpoint formatting
test/unit/base.go	Enhanced test base to support v4beta endpoint mocking
test/unit/monitor_alert_definitions_test.go	Comprehensive unit tests for alert definitions functionality
test/integration/monitor_alert_definitions_test.go	Integration test with real API interaction scenarios
test/integration/fixtures/TestMonitorAlertDefinition_instance.yaml	Test fixture data for integration testing

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

test/integration/monitor_alert_definitions_test.go

monitor_alert_definitions.go

Copilot

Pull Request Overview

Copilot reviewed 77 out of 81 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yec-akamai

It seems some unrelated commits are added accidentally. Do you mind cleaning up the branch and fixing the conflicts?

lgarber-akamai · 2025-11-12T18:11:29Z

@srbhaakamai Just bumping Ye's comment — could you resolve the conflicts and unrelated comments on this branch? I'm happy to do it too and push up the new commit if you'd like

lgarber-akamai · 2025-11-13T16:05:01Z

@srbhaakamai I just finished up fixing up the commit history and will be providing a review shortly 👍

request_helpers.go

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

monitor_dashboards.go

test/integration/monitor_alert_definitions_test.go

srbhaakamai · 2025-12-10T11:17:20Z

@yec-akamai thanks for the valuable review comments. i fixed all of them and kept 2 as i dont understand them, please check and let me know if my answers address your concerns.

All other comments are addressed committed tested locally and pushed to branch for review.

srbhaakamai · 2025-12-10T11:24:29Z

@yec-akamai i am not clear on merge conflict , i mean which one to chose so , please help me or resolve that.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

alert_channels.go

yec-akamai

Can you also update the integration test fixtures given the structs have changed?

monitor_alert_definitions.go

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

yec-akamai

Thanks for addressing previous comments. Can you fix the integration test failures and lint issues?

monitor_alert_definitions.go

srbhaakamai · 2025-12-19T04:06:19Z

@yec-akamai csn we trigger CI test and see if it passes now, i ran locally and its working fine.

alert_channels.go

monitor_alert_definitions.go

zliang-akamai · 2025-12-22T20:58:47Z

monitor_alert_definitions.go

+	RuleCriteria      RuleCriteriaOptions `json:"rule_criteria"`         // optional
+	TriggerConditions TriggerConditions   `json:"trigger_conditions"`    // optional


omitempty should apply to all option fields, and optional fields should be pointers with an exception of nil-able slice

zliang-akamai · 2025-12-22T20:59:09Z

monitor_alert_definitions.go

+	RuleCriteria      RuleCriteriaOptions `json:"rule_criteria"`         // optional
+	TriggerConditions TriggerConditions   `json:"trigger_conditions"`    // optional
+	EntityIDs         []string            `json:"entity_ids,omitempty"`  // optional
+	Description       string              `json:"description,omitempty"` // optional


Same problems here

zliang-akamai · 2025-12-22T21:03:34Z

monitor_alert_definitions.go

+// ListMonitorAlertDefinitions returns a paginated list of ACLP Monitor Alert Definitions by service type.
+func (c *Client) ListMonitorAlertDefinitions(
+	ctx context.Context,
+	serviceType string,


Should serviceType be ServiceType Enum type?

zliang-akamai · 2025-12-22T21:44:09Z

test/integration/monitor_alert_definitions_test.go

+	// Cleanup
+	if createdAlert != nil {
+		_ = client.DeleteMonitorAlertDefinition(context.Background(), testMonitorAlertDefinitionServiceType, createdAlert.ID)
+	}


Cleanup logic should be wrapped in a function and called via defer key word to ensure it's always executed even if a hard failure (fatal) is in the test case.

srbhaakamai requested a review from a team as a code owner September 15, 2025 13:55

srbhaakamai requested review from Copilot, jriddle-linode and yec-akamai and removed request for a team September 15, 2025 13:55

srbhaakamai marked this pull request as draft September 15, 2025 13:55

Copilot AI reviewed Sep 15, 2025

View reviewed changes

srbhaakamai closed this Oct 4, 2025

srbhaakamai reopened this Oct 4, 2025

srbhaakamai force-pushed the main branch 3 times, most recently from 9226cfb to 8e71881 Compare October 4, 2025 04:43

srbhaakamai marked this pull request as ready for review October 13, 2025 11:04

lgarber-akamai self-requested a review October 31, 2025 16:51

yec-akamai requested a review from Copilot November 4, 2025 19:01

Copilot AI reviewed Nov 4, 2025

View reviewed changes

yec-akamai reviewed Nov 4, 2025

View reviewed changes

lgarber-akamai force-pushed the main branch 2 times, most recently from 7818a6b to aed99f8 Compare November 13, 2025 16:02

DI-27070 Add support for ACLP alerting

3001996

lgarber-akamai force-pushed the main branch from aed99f8 to 3001996 Compare November 13, 2025 16:03

Fix lint

625296b

lgarber-akamai reviewed Nov 13, 2025

View reviewed changes

request_helpers.go Outdated Show resolved Hide resolved

lgarber-akamai requested a review from Copilot November 13, 2025 18:58

Copilot AI reviewed Nov 13, 2025

View reviewed changes

monitor_dashboards.go Show resolved Hide resolved

test/integration/monitor_alert_definitions_test.go Outdated Show resolved Hide resolved

test/integration/monitor_alert_definitions_test.go Show resolved Hide resolved

Fix deprecation formatting

926f2a0

lgarber-akamai requested a review from yec-akamai November 13, 2025 19:38

Fix lint

d72eefa

Fixed review comments

a4c44e2

ezilber-akamai added 2 commits December 16, 2025 09:12

Merge branch 'main' into main

093163e

Ran make tidy

164a464

zliang-akamai requested review from Copilot and yec-akamai December 16, 2025 17:08

Copilot AI reviewed Dec 16, 2025

View reviewed changes

alert_channels.go Outdated Show resolved Hide resolved

alert_channels.go Outdated Show resolved Hide resolved

linode deleted a comment from Copilot AI Dec 16, 2025

fixed review comments from ye-chen and copilot

03831e1

yec-akamai requested changes Dec 17, 2025

View reviewed changes

monitor_alert_definitions.go Outdated Show resolved Hide resolved

monitor_alert_definitions.go Show resolved Hide resolved

monitor_alert_definitions.go Outdated Show resolved Hide resolved

monitor_alert_definitions.go Outdated Show resolved Hide resolved

srbhaakamai and others added 3 commits December 18, 2025 11:44

Apply suggestion from @yec-akamai

9c2b0e4

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

fixed fixtures and other review comments

5da0bdf

Merge branch 'main' into main

ba2563f

yec-akamai reviewed Dec 18, 2025

View reviewed changes

monitor_alert_definitions.go Outdated Show resolved Hide resolved

fixed comments and lint errors

8f24b73

yec-akamai reviewed Dec 19, 2025

View reviewed changes

alert_channels.go Outdated Show resolved Hide resolved

monitor_alert_definitions.go Show resolved Hide resolved

yec-akamai added 3 commits December 22, 2025 10:16

fix fixtures

d0ad712

fix alert channel type

c823d20

import resort

77d36ee

yec-akamai approved these changes Dec 22, 2025

View reviewed changes

ezilber-akamai approved these changes Dec 22, 2025

View reviewed changes

Merge branch 'main' into main

e7a4f8b

yec-akamai merged commit 3c29b43 into linode:main Dec 22, 2025
10 checks passed

zliang-akamai reviewed Dec 22, 2025

View reviewed changes

zliang-akamai mentioned this pull request Dec 22, 2025

Fix Multiple ACLP Alerting Issues #873

Merged

		RuleCriteria RuleCriteriaOptions `json:"rule_criteria"` // optional
		TriggerConditions TriggerConditions `json:"trigger_conditions"` // optional

ACLP Alerting go SDK #824

ACLP Alerting go SDK #824

Uh oh!

Conversation

srbhaakamai commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

📷 Preview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

lgarber-akamai commented Nov 12, 2025

Uh oh!

lgarber-akamai commented Nov 13, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

srbhaakamai commented Dec 10, 2025

Uh oh!

srbhaakamai commented Dec 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

srbhaakamai commented Dec 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zliang-akamai Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

zliang-akamai Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

zliang-akamai Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zliang-akamai Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

srbhaakamai commented Sep 15, 2025 •

edited

Loading

zliang-akamai Dec 22, 2025 •

edited

Loading

zliang-akamai Dec 22, 2025 •

edited

Loading