Fix Multiple ACLP Alerting Issues #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
ezilber-akamai and
vshanthe
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issues found in a previous pull request by cleaning up the monitor alert definitions implementation. The changes focus on removing unnecessary API version handling, standardizing test naming, updating type definitions to use pointers for optional fields, and simplifying endpoint construction logic.
- Removed beta endpoint registration logic from unit test mocking methods
- Converted optional struct fields to pointers in AlertDefinitionCreateOptions and AlertDefinitionUpdateOptions
- Renamed test functions to follow consistent naming conventions
- Simplified ListMonitorAlertDefinitions endpoint construction
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unit/base.go | Removed beta endpoint registration logic and unused strings import from mock HTTP methods |
| test/integration/monitor_alert_definitions_test.go | Updated tests to use pointer types for optional fields, removed API version calls, renamed tests to follow naming conventions, and updated function calls to use ListAllMonitorAlertDefinitions |
| test/integration/fixtures/TestMonitorAlertDefinitions_List.yaml | New fixture file for the renamed TestMonitorAlertDefinitions_List test |
| test/integration/fixtures/TestMonitorAlertDefinition_Smoke.yaml | New fixture file for the renamed TestMonitorAlertDefinition_smoke test |
| test/integration/fixtures/TestMonitorAlertDefinition_CreateWithIdempotency.yaml | New fixture file for the renamed TestMonitorAlertDefinition_CreateWithIdempotency test |
| test/integration/fixtures/TestMonitorAlertChannels_List.yaml | New fixture file for the renamed TestMonitorAlertChannels_List test |
| monitor_alert_definitions.go | Changed optional fields to pointer types in AlertDefinitionCreateOptions and AlertDefinitionUpdateOptions structs, simplified endpoint construction in ListMonitorAlertDefinitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
approved these changes
Dec 23, 2025
yec-akamai
approved these changes
Dec 23, 2025
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Thanks for fixing these issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to clean up the issues found in #824
One remaining but less urgent issue is that the cleanup logic of the tests should wrapped in a function and called via
t.Cleanup(someFunction())ordefer someFunction().✔️ How to Test
make TEST_ARGS="-run TestMonitorAlert" fixtures