loopd: rename server.tlspath to server.tlscertpath#1107
loopd: rename server.tlspath to server.tlscertpath#1107lightninglabs-deploy wants to merge 1 commit intolightninglabs:masterfrom
Conversation
Rename the `--server.tlspath` flag to `--server.tlscertpath` for consistency with the naming convention used across the rest of the codebase (e.g. `--tlscertpath`, `--lnd.tlspath`). The flag now defaults to the aperture TLS certificate path in the default aperture data directory (`~/.aperture/tls.cert`), so users running aperture with the default configuration no longer need to explicitly specify this flag.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the naming convention for TLS certificate paths across the project's configuration and internal structures. By renaming the server TLS path flag and providing a sensible default, the change simplifies the setup process for users while ensuring the codebase adheres to a more uniform naming pattern. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request renames TLS path configuration fields and flags across the codebase (e.g., from TLSPath to TLSCertPath) to clarify that they refer specifically to certificate files. It also introduces a default path for the Aperture TLS certificate and updates the relevant configuration logic, Docker Compose files, and sample configuration. I have no feedback to provide.
|
Opened against the wrong repo — the flag rename belongs in aperture, not loop. See lightninglabs/aperture#228 |
Summary
--server.tlspathflag to--server.tlscertpathfor consistency with naming conventions used across the codebase (--tlscertpath,--lnd.tlspath, etc.)~/.aperture/tls.cert, so users running aperture with default configuration no longer need to explicitly specify this flagClientConfig.TLSPathServer→TLSCertPathServerfor internal consistencyFiles changed
loopd/config.go— renamed field, addedApertureDirBaseandDefaultApertureTLSCertPath, set default inDefaultConfig()client.go— renamedTLSPathServer→TLSCertPathServerloopd/utils.go— updated field referenceswap_server_client.go— updated field referencesample-loopd.conf— updated flag name and example defaultregtest/docker-compose.yml— updated flag name