Skip to content

loopd: rename server.tlspath to server.tlscertpath#1107

Closed
lightninglabs-deploy wants to merge 1 commit intolightninglabs:masterfrom
lightninglabs-deploy:fix/rename-server-tlscertpath
Closed

loopd: rename server.tlspath to server.tlscertpath#1107
lightninglabs-deploy wants to merge 1 commit intolightninglabs:masterfrom
lightninglabs-deploy:fix/rename-server-tlscertpath

Conversation

@lightninglabs-deploy
Copy link
Copy Markdown

Summary

  • Renames --server.tlspath flag to --server.tlscertpath for consistency with naming conventions used across the codebase (--tlscertpath, --lnd.tlspath, etc.)
  • Defaults the flag to ~/.aperture/tls.cert, so users running aperture with default configuration no longer need to explicitly specify this flag
  • Updates ClientConfig.TLSPathServerTLSCertPathServer for internal consistency

Files changed

  • loopd/config.go — renamed field, added ApertureDirBase and DefaultApertureTLSCertPath, set default in DefaultConfig()
  • client.go — renamed TLSPathServerTLSCertPathServer
  • loopd/utils.go — updated field reference
  • swap_server_client.go — updated field reference
  • sample-loopd.conf — updated flag name and example default
  • regtest/docker-compose.yml — updated flag name

Rename the `--server.tlspath` flag to `--server.tlscertpath` for
consistency with the naming convention used across the rest of the
codebase (e.g. `--tlscertpath`, `--lnd.tlspath`).

The flag now defaults to the aperture TLS certificate path in the
default aperture data directory (`~/.aperture/tls.cert`), so users
running aperture with the default configuration no longer need to
explicitly specify this flag.
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the naming convention for TLS certificate paths across the project's configuration and internal structures. By renaming the server TLS path flag and providing a sensible default, the change simplifies the setup process for users while ensuring the codebase adheres to a more uniform naming pattern.

Highlights

  • Flag Renaming: Renamed the --server.tlspath configuration flag to --server.tlscertpath to improve consistency with existing codebase naming conventions.
  • Default Configuration: Implemented a default value for the TLS certificate path, pointing to ~/.aperture/tls.cert, reducing the need for manual configuration.
  • Internal Refactoring: Updated internal struct fields and references from TLSPathServer to TLSCertPathServer to maintain consistency across the application.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames TLS path configuration fields and flags across the codebase (e.g., from TLSPath to TLSCertPath) to clarify that they refer specifically to certificate files. It also introduces a default path for the Aperture TLS certificate and updates the relevant configuration logic, Docker Compose files, and sample configuration. I have no feedback to provide.

@lightninglabs-deploy
Copy link
Copy Markdown
Author

Opened against the wrong repo — the flag rename belongs in aperture, not loop. See lightninglabs/aperture#228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant