Skip to content

Use DirEntry::file_type rather than metadata... in list #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 1 commit into from
Feb 10, 2026
+3 −3
Merged

Use DirEntry::file_type rather than metadata... in list #4404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lightning-persister/src/fs_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,15 +560,15 @@ fn dir_entry_is_key(dir_entry: &fs::DirEntry) -> Result<bool, lightning::io::Err
}
}

let metadata = dir_entry.metadata()?;
let file_type = dir_entry.file_type()?;

// We allow the presence of directories in the empty primary namespace and just skip them.
if metadata.is_dir() {
if file_type.is_dir() {
return Ok(false);
}

// If we otherwise don't find a file at the given path something went wrong.
if !metadata.is_file() {
if !file_type.is_file() {
debug_assert!(
false,
"Failed to list keys at path {}: file couldn't be accessed.",
Expand Down
Loading