Use DirEntry::file_type rather than metadata... in list
#4404
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the discussions at lightningdevkit#3799 it was noted that `DirEntry::file_type` will often use cached information rather than making a fresh syscall, fixing the `list` race condition where we lose files while iterating the directory for some filesystems on some Unix platforms. For some reason, that fix didn't make it into the merged PR, and we rather stuck with `DirEntry::metadata()` which *always* does a fresh syscall and always exhibits the problematic behavior. Here we simply swap for `DirEntry::file_type` which at least fixes the issue for "some filesome filesystems (among them: Btrfs, ext2, ext3, and ext4)" (per `readdir(3)`).
|
👋 Thanks for assigning @tnull as a reviewer! |
valentinewallace
approved these changes
Feb 9, 2026
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4404 +/- ##
==========================================
- Coverage 86.02% 86.02% -0.01%
==========================================
Files 156 156
Lines 103100 103100
Branches 103100 103100
==========================================
- Hits 88693 88691 -2
+ Misses 11896 11895 -1
- Partials 2511 2514 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussions at #3799 it was noted that
DirEntry::file_typewill often use cached information rather than making a fresh syscall, fixing thelistrace condition where we lose files while iterating the directory for some filesystems on some Unix platforms.For some reason, that fix didn't make it into the merged PR, and we rather stuck with
DirEntry::metadata()which always does a fresh syscall and always exhibits the problematic behavior. Here we simply swap forDirEntry::file_typewhich at least fixes the issue for "some filesome filesystems (among them: Btrfs, ext2, ext3, and ext4)" (perreaddir(3)).