Skip to content

feat(SimpleGraph): rename cycleGraph_EulerianCircuit to cycleGraph.cycle#35360

Open
vlad902 wants to merge 1 commit intoleanprover-community:masterfrom
vlad902:rename-euleriancircuit
Open

feat(SimpleGraph): rename cycleGraph_EulerianCircuit to cycleGraph.cycle#35360
vlad902 wants to merge 1 commit intoleanprover-community:masterfrom
vlad902:rename-euleriancircuit

Conversation

@vlad902
Copy link
Collaborator

@vlad902 vlad902 commented Feb 15, 2026

Per this review feedback, this definition is inappropriately named with an underscore and should be renamed.


Open in Gitpod

….cycle`

Per
[this](leanprover-community#34797 (comment))
review feedback, this definition is inappropriately named with an
underscore and should be renamed.
@vlad902
Copy link
Collaborator Author

vlad902 commented Feb 15, 2026

cc @IvanRenison the original author if you have a different opinion about the name.

@github-actions
Copy link

PR summary 81b174f9de

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cycleGraph.cycle
+ cycleGraph.cycle_cons
+ cycleGraph.cycle_cons_length
+ cycleGraph.cycle_length
- cycleGraph_EulerianCircuit_cons
- cycleGraph_EulerianCircuit_cons_length

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-combinatorics Combinatorics label Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant