Skip to content

feat(SimpleGraph): cycleGraph_EulerianCircuit is a cycle#34797

Open
vlad902 wants to merge 5 commits intoleanprover-community:masterfrom
vlad902:cycleGraph-eulerianCircuit
Open

feat(SimpleGraph): cycleGraph_EulerianCircuit is a cycle#34797
vlad902 wants to merge 5 commits intoleanprover-community:masterfrom
vlad902:cycleGraph-eulerianCircuit

Conversation

@vlad902
Copy link
Collaborator

@vlad902 vlad902 commented Feb 3, 2026

@vlad902 vlad902 changed the title feat(SimpleGraph): cycleGraph is a cycle and IsContained in every graph with a cycle feat(SimpleGraph): cycleGraph is a cycle and IsContained in every graph with a cycle Feb 3, 2026
@github-actions github-actions bot added the t-combinatorics Combinatorics label Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

PR summary 81b174f9de

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cycleGraph_EulerianCircuit_cons_getVert
+ cycleGraph_EulerianCircuit_getVert
+ cycleGraph_EulerianCircuit_isCycle
+ cycleGraph_EulerianCircuit_tail_isPath

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 3, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 9, 2026
Prove that `cycleGraph_EulerianCircuit` is a cycle and as a consequence
that a graph contains a cycleGraph iff it has a cycle of that length.

(A follow-up PR will show that `cycleGraph_EulerianCircuit` is also
hamiltonian.)
@vlad902 vlad902 force-pushed the cycleGraph-eulerianCircuit branch from e3a8af9 to a04966e Compare February 13, 2026 13:55
@vlad902 vlad902 changed the title feat(SimpleGraph): cycleGraph is a cycle and IsContained in every graph with a cycle feat(SimpleGraph): cycleGraph is a cycle Feb 13, 2026
@vlad902 vlad902 changed the title feat(SimpleGraph): cycleGraph is a cycle feat(SimpleGraph): cycleGraph_EulerianCircuit is a cycle Feb 13, 2026
set_option backward.privateInPublic true in
set_option backward.privateInPublic.warn false in
/-- Eulerian trail of `cycleGraph (n + 3)` -/
def cycleGraph_EulerianCircuit (n : ℕ) : (cycleGraph (n + 3)).Walk 0 0 :=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misnamed - there should be no underscore in the name of a def. I propose renaming it and everything that refers to it (with deprecation) before adding more misnamed theorems.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 14, 2026
vlad902 added a commit to vlad902/mathlib4 that referenced this pull request Feb 15, 2026
….cycle`

Per
[this](leanprover-community#34797 (comment))
review feedback, this definition is inappropriately named with an
underscore and should be renamed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants