feat(SimpleGraph): cycleGraph_EulerianCircuit is a cycle#34797
Open
vlad902 wants to merge 5 commits intoleanprover-community:masterfrom
Open
feat(SimpleGraph): cycleGraph_EulerianCircuit is a cycle#34797vlad902 wants to merge 5 commits intoleanprover-community:masterfrom
cycleGraph_EulerianCircuit is a cycle#34797vlad902 wants to merge 5 commits intoleanprover-community:masterfrom
Conversation
cycleGraph is a cycle and IsContained in every graph with a cyclecycleGraph is a cycle and IsContained in every graph with a cycle
PR summary 81b174f9deImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
2 tasks
vlad902
commented
Feb 3, 2026
vlad902
commented
Feb 6, 2026
Prove that `cycleGraph_EulerianCircuit` is a cycle and as a consequence that a graph contains a cycleGraph iff it has a cycle of that length. (A follow-up PR will show that `cycleGraph_EulerianCircuit` is also hamiltonian.)
e3a8af9 to
a04966e
Compare
cycleGraph is a cycle and IsContained in every graph with a cyclecycleGraph is a cycle
cycleGraph is a cyclecycleGraph_EulerianCircuit is a cycle
| set_option backward.privateInPublic true in | ||
| set_option backward.privateInPublic.warn false in | ||
| /-- Eulerian trail of `cycleGraph (n + 3)` -/ | ||
| def cycleGraph_EulerianCircuit (n : ℕ) : (cycleGraph (n + 3)).Walk 0 0 := |
Contributor
There was a problem hiding this comment.
This is misnamed - there should be no underscore in the name of a def. I propose renaming it and everything that refers to it (with deprecation) before adding more misnamed theorems.
vlad902
added a commit
to vlad902/mathlib4
that referenced
this pull request
Feb 15, 2026
….cycle` Per [this](leanprover-community#34797 (comment)) review feedback, this definition is inappropriately named with an underscore and should be renamed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(A follow-up PR will show that
cycleGraph_EulerianCircuitis also hamiltonian.)