clean up tests in preparation for ports-of-call variant transition #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This MR is motivated by #590 , where
test_ptewas failing. I tracked this down to LLVM versions < 19, which apparently produce problematic device code. Now for AMD GPU builds, if the clang compiler version is less than 19, this test is disabled and a warning is emitted.In the process, I also cleaned up a few minor things:
test_pte.cpphas been re-written slightly for clarity. The main test function no longer returns any values, but sets relevant quantities by reference.test_spiner_transform.cppwas being improperly compiled when spiner was enabled by HDF5 was not. This has been resolved.PR Checklist
make formatcommand after configuring withcmake.If preparing for a new release, in addition please check the following:
when='@main'dependencies are updated to the release version in the package.py