clean up tests and guard for AMD builds for problematic clang versions #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following lines in a merge request description now have special meaning: Deployment Version: YYYY-MM-DD Requires: https://re-git.lanl.gov/xcap/deployment/-/merge_requests/### Requires: https://re-git.lanl.gov/xcap/spackages/-/merge_requests/### Deployment version changes the default deployment version that should be used. Requires A xcap/deployment MR URL will change the CI to use the MR deployment with the same MR ID, together with either the default deployment version or another if specified via "Deployment Version". This replaces the "mr/###/YYYY-MM-DD" value that was set as PROJECT_SPACK_ENV_VERSION previously. A xcap/spackages MR URL will change the checkout of xcap/spackages to that particular MR to facilitate testing of Spack package changes. Explicitly setting PROJECT_SPACK_ENV_VERSION or XCAP_SPACKAGES_REF can be used to override these detections.
…o' into jmm/ports-testing
….gov:10022/xcap/oss/singularity-eos into rberger/remove_project_spack_repo
This reverts commit 7f47b2a.
This reverts commit 994fe2a.
…ner_transforms behind HDF5
Collaborator
Author
|
Superseded by #594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This MR addesses the issue that on rzadams versions of the llvm backend for llvm less than 19 cause problems. I now guard behind a version check in cmake. I also take advantage of the MR to clean up some minor issues with tests and formatting. There was a missing guard in the test singularity transforms file, and test_pte is slightly rewritten for clarity.
PR Checklist
make formatcommand after configuring withcmake.If preparing for a new release, in addition please check the following:
when='@main'dependencies are updated to the release version in the package.py