Skip to content

Remove local spack-repo, update gitlab CI, and use PortsOfCall::variant #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbberger merged 10 commits into from
Dec 13, 2025
Merged

Remove local spack-repo, update gitlab CI, and use PortsOfCall::variant #590

rbberger merged 10 commits into from
Dec 13, 2025

Conversation

@rbberger
Copy link
Collaborator

@rbberger rbberger commented Dec 1, 2025 •
edited
Loading

PR Summary

  • This PR removes the local spack-repo of singularity-eos. The primary purpose of that local spack repository was facilitating internal testing at LANL. Please see https://github.com/spack/spack-packages for current versions of our Spack package.
  • It also removes the dependency to mpark variant, since it is now provided by ports-of-call.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur mentioned this pull request Dec 10, 2025
Merged
9 tasks
@rbberger rbberger force-pushed the rberger/remove_project_spack_repo branch 2 times, most recently from a79d28f to 21da0ce Compare December 10, 2025 22:38
Yurlungur
Yurlungur approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1796 lines! 🎊 Merge when ready.

@rbberger rbberger changed the title Remove local spack-repo and update gitlab CI Remove local spack-repo, update gitlab CI, and use PortsOfCall::variant Dec 10, 2025
@rbberger rbberger force-pushed the rberger/remove_project_spack_repo branch from a3dcd7a to 80195e0 Compare December 10, 2025 23:54
@Yurlungur Yurlungur mentioned this pull request Dec 12, 2025
Merged
9 tasks
@rbberger
github: remove robots
59c64f5
@rbberger
ci: use xcap/spackages
ad6c396
@rbberger
ci: remove rzansel jobs and post directly to cdash from RZ
73c6d0f
@rbberger
ci: replace env vars with mr description hooks
26fdbac 
The following lines in a merge request description now have special meaning:

Deployment Version: YYYY-MM-DD
Requires: https://re-git.lanl.gov/xcap/deployment/-/merge_requests/###
Requires: https://re-git.lanl.gov/xcap/spackages/-/merge_requests/###

Deployment version
  changes the default deployment version that should be used.

Requires
  A xcap/deployment MR URL will change the CI to use the MR deployment with the
  same MR ID, together with either the default deployment version or another if
  specified via "Deployment Version". This replaces the "mr/###/YYYY-MM-DD"
  value that was set as PROJECT_SPACK_ENV_VERSION previously.

  A xcap/spackages MR URL will change the checkout of xcap/spackages to that
  particular MR to facilitate testing of Spack package changes.

Explicitly setting PROJECT_SPACK_ENV_VERSION or XCAP_SPACKAGES_REF can be used
to override these detections.
@rbberger
use PortsOfCall::variant
e4cb77e
@rbberger
docs: remove mention of spack-repo
02dcdef
@rbberger
update spiner and ports-of-call submodules
14d0d7f
@rbberger
formatting
718f613
@rbberger
Update CHANGELOG.md
e6bf199
@rbberger
bump spiner submodule to fix cmake issue
cac52aa
@rbberger rbberger force-pushed the rberger/remove_project_spack_repo branch from 80195e0 to cac52aa Compare December 12, 2025 23:52
@rbberger rbberger merged commit 0ad3db2 into main Dec 13, 2025
9 checks passed
@rbberger rbberger deleted the rberger/remove_project_spack_repo branch December 13, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbberger @Yurlungur