Skip to content

Fix a failing unit test on Windows #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwb27 merged 2 commits into from
Jan 12, 2026
Merged

Fix a failing unit test on Windows #250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6355f4
Fix a failing unit test on Windows
rwb27 Jan 12, 2026
ba819b6
Use os.path.join because it's neater
rwb27 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_fallback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"""

import logging
import os
import re
from html import unescape

Expand Down Expand Up @@ -186,6 +187,7 @@ def test_actual_server_fallback():

# The message from when the Thing errored should be displayed
assert str(thing_error) in unescape(html)
# With the traceback
assert 'labthings_fastapi/example_things/__init__.py", line' in unescape(html)
# With the traceback (NB we need os.path.join to get correct slashes on Windows)
fpath = os.path.join("labthings_fastapi", "example_things", "__init__.py")
assert fpath in unescape(html)
assert f'RuntimeError("{thing_error}")' in unescape(html)