Fix a failing unit test on Windows #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short of fixing Windows so it uses sensible path separators, this feels like a reasonable work-around.
Barecheck - Code coverage reportTotal: 96.33%Your code coverage diff: 0.03% ▴ ✅ All code changes are covered |
julianstirling
approved these changes
Jan 12, 2026
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
Sorry for the Os dependent unit test, thanks for the fix.
This feels nicer than hard coding two strings for Linux/Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short of fixing Windows so it uses sensible path separators, this feels like a reasonable work-around. The test failed because the path used
\\as a separator. I've just provided two forms of the path - it's not beautiful, but it's clear and it works.