Skip to content

[occm] Skip LB rename for shared load balancers from other clusters #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
234u34k wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −6
Open

[occm] Skip LB rename for shared load balancers from other clusters #3079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions pkg/openstack/loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,13 +1695,20 @@ func (lbaas *LbaasV2) ensureOctaviaLoadBalancer(ctx context.Context, clusterName
}

// Here we test for a clusterName that could have had changed in the deployment.
// Only rename when the LB was originally created for this Service (i.e. the
// namespace and service name components match). Without this guard, a shared
// LB from a different cluster gets incorrectly renamed.
if lbHasOldClusterName(loadbalancer, clusterName) {
msg := "Loadbalancer %s has a name of %s with incorrect cluster-name component. Renaming it to %s."
klog.Infof(msg, loadbalancer.ID, loadbalancer.Name, lbName)
lbaas.eventRecorder.Eventf(service, corev1.EventTypeWarning, eventLBRename, msg, loadbalancer.ID, loadbalancer.Name, lbName)
loadbalancer, err = renameLoadBalancer(ctx, lbaas.lb, loadbalancer, lbName, clusterName)
if err != nil {
return nil, fmt.Errorf("failed to update load balancer %s with an updated name: %w", svcConf.lbID, err)
oldClusterName := getClusterName("", loadbalancer.Name)
expectedOldName := cpoutil.Sprintf255(lbFormat, servicePrefix, oldClusterName, service.Namespace, service.Name)
if loadbalancer.Name == expectedOldName {
msg := "Loadbalancer %s has a name of %s with incorrect cluster-name component. Renaming it to %s."
klog.Infof(msg, loadbalancer.ID, loadbalancer.Name, lbName)
lbaas.eventRecorder.Eventf(service, corev1.EventTypeWarning, eventLBRename, msg, loadbalancer.ID, loadbalancer.Name, lbName)
loadbalancer, err = renameLoadBalancer(ctx, lbaas.lb, loadbalancer, lbName, clusterName)
if err != nil {
return nil, fmt.Errorf("failed to update load balancer %s with an updated name: %w", svcConf.lbID, err)
}
}
}

Expand Down