[occm] Skip LB rename for shared load balancers from other clusters#3079
[occm] Skip LB rename for shared load balancers from other clusters#3079234u34k wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @234u34k. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/S
When a Service references a shared load balancer via annotation, the OCCM rename logic (added in kubernetes#2552) sees a different cluster name in the LB name and renames it. This breaks multi-cluster shared LB setups because the owning cluster loses its LB name and tags. Before renaming, verify that the LB's namespace and service name components match the current Service. This distinguishes a legitimate cluster-name change (same service, new cluster name) from a cross-cluster shared LB access (different service entirely).
234u34k
force-pushed
the
fix/shared-lb-rename-guard
branch
from
f89465f to
d223a02
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
2 participants
The cluster-name rename logic from #2552 does not account for shared load balancers. When cluster B references a shared LB created by cluster A, the OCCM sees a mismatched cluster name and renames the LB, breaking cluster A.
Before renaming, verify that the LB's namespace and service name components match the current Service. This distinguishes a legitimate cluster-name change from a cross-cluster shared LB access.
Ref #2682