docs(web): improve documentation on addKeyboards/addKeyboardsForLanguage#16020
Open
ermshiperete wants to merge 2 commits into
Open
docs(web): improve documentation on addKeyboards/addKeyboardsForLanguage#16020ermshiperete wants to merge 2 commits into
addKeyboards/addKeyboardsForLanguage#16020ermshiperete wants to merge 2 commits into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
commented
May 27, 2026
| There are multiple ways to add and install keyboards into your KeymanWeb installation. | ||
|
|
||
| ## Directly linking a local copy | ||
| ## Requesting from the Keyman cloud (CDN) |
Contributor
Author
There was a problem hiding this comment.
I decided to change the order so that the simpler cases come first. This also matches the order of the parameter description in addKeyboards.md.
ermshiperete
force-pushed
the
docs/web/addKeyboards
branch
from
6aa831c to
45e48e1
Compare
…nguage` Also improve types on signature of those functions. Fixes: keymanapp/help.keyman.com#365 Build-bot: skip build:web Test-bot: skip
ermshiperete
force-pushed
the
docs/web/addKeyboards
branch
from
45e48e1 to
47ec50b
Compare
ermshiperete
commented
May 28, 2026
Comment on lines
+47
to
+49
| await keyman.addKeyboards('@fr$'); | ||
| // or | ||
| await keyman.addKeyboardsForLanguage('French$'); |
mcdurdin
approved these changes
May 28, 2026
Comment on lines
+47
to
+49
| await keyman.addKeyboards('@fr$'); | ||
| // or | ||
| await keyman.addKeyboardsForLanguage('French$'); |
Member
There was a problem hiding this comment.
If not working, should we remove from the active docs and leave it to re-add when #16018 is resolved?
Comment on lines
+57
to
+58
| If the BCP47 language code is suffixed with `$` (e.g. `@fr$`) and no specific keyboard is | ||
| requested, all keyboards for that language code will be loaded. |
Member
There was a problem hiding this comment.
As this doesn't work, we shouldn't add it currently
Contributor
Author
|
Do not merge until #16018 is fixed - or the corresponding sections from the docs removed. |
Co-authored-by: Marc Durdin <marc@durdin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improve types on signature of those functions.
Fixes: keymanapp/help.keyman.com#365
Build-bot: skip build:web
Test-bot: skip