fix: linter in echo-sql and book-inventory app#201
Merged
khareyash05 merged 1 commit intokeploy:mainfrom Feb 12, 2026
Merged
Conversation
Signed-off-by: Saket Maurya <mauryapriyadarshi2004@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes golangci-lint/errcheck findings in the Go example apps by properly handling errors returned from deferred/cleanup calls (logger sync and SQL rows close), aligning with the repo’s enabled errcheck linter.
Changes:
- Handle and log
Logger.Sync()errors before exiting on DB connection failure inecho-sql. - Wrap
rows.Close()in a deferred function that checks/logs the close error inbook-store-inventory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
echo-sql/main.go |
Checks Logger.Sync() error before Logger.Fatal to satisfy errcheck and improve shutdown behavior. |
book-store-inventory/pkg/repositories/book_repository.go |
Checks rows.Close() error in a deferred closure to prevent resource leak warnings and satisfy errcheck. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Fix linter issues in Go example apps
This PR fixes linter errors in the
echo-sqlandbook-store inventoryapplications.