This PR fixes golangci-lint CI failures caused by unchecked error returns in Go samples.#202
Closed
DARSHAN-R-DARSHAN wants to merge 2 commits intokeploy:mainfrom
Closed
Conversation
Signed-off-by: DARSHAN-R-DARSHAN <darshanramanji07@gmail.com>
Signed-off-by: DARSHAN-R-DARSHAN <darshanramanji07@gmail.com>
DARSHAN-R-DARSHAN
force-pushed
the
fix/golangci-lint-failures
branch
from
bf7bc4f to
afdb0b8
Compare
Author
|
Hi! @khareyash05, I have fixed the issue. |
Member
|
Duplicate #201 |
Author
|
Thanks @khareyash05 for letting me know! I’ll look into another issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: keploy/keploy#3758
What was fixed
sql.Rows.Close()in book-store-inventory to satisfy errcheck.Logger.Sync()inecho-sql, including the error path beforeLogger.Fatal.How this was tested
Ran golangci-lint run locally inside:
book-store-inventory
echo-sql
Verified that GitHub Actions CI passes successfully.