-
-
Notifications
You must be signed in to change notification settings - Fork 289
fix: docs UI improvements — navbar link, heading styles, footer layout, banner #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f58c96f
feat: Phase 3 SEO — glossary titles, freshness signals, noindex old v…
slayerjain 0f994e9
fix: update Integration Testing navbar link to /install
slayerjain 0bea404
fix: remove top gap on docs pages
slayerjain 26a5369
fix: remove top gap above breadcrumbs and restyle announcement bar
slayerjain 7d319a1
fix: update heading colors to brand blue and remove v3 h1 emojis
slayerjain 22a5523
fix: scope footer to content area so sidebar runs full-height
slayerjain 21bf105
Merge branch 'main' into fix/navbar-integration-testing-link
nehagup 36f7ac1
fix: remove Disallow for old doc versions from robots.txt
slayerjain dcbb418
fix: build failures — correct install route, prettier, footer cascade
slayerjain e558ae9
fix: address Copilot review — @import order, footer CSS variable, PR …
slayerjain b06a239
fix: scope docusaurus-mt-lg override to docs pages, fix v3 install links
slayerjain 6a139a1
fix: revert announcement bar text, scope tablet breakpoints to desktop
slayerjain dc0456a
fix: narrow announcement bar selector to top-level container only
slayerjain 0122bb4
fix: improve link contrast in banner, load font via headTags
slayerjain bedfea3
fix: correct misleading comment about font loading strategy
slayerjain dc60e6f
fix: use --doc-sidebar-width variable for sidebar container width
slayerjain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description/test plan says the navbar should route to
/docs/install, but the actual navbar target isserver/install(which will resolve to/server/installunderrouteBasePath: "/", plus the sitebaseUrl). To avoid confusion for reviewers, align the description/test plan with the actual route (or adjust thistovalue if/installis the intended URL).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — updated the PR description to say
/docs/server/installto match the actualto: "server/install"navbar target.