fix: docs UI improvements — navbar link, heading styles, footer layout, banner#821
fix: docs UI improvements — navbar link, heading styles, footer layout, banner#821
Conversation
…ersions Task 68 — Rewrite 10 glossary page titles for CTR optimization: - "Idempotency" → "What is Idempotency in REST APIs? Complete Guide" - "Black Box Testing" → "What is Black Box Testing? Types & Examples" - Plus 8 more glossary pages with question-format titles - Added 140-155 char meta descriptions to all 10 pages Task 22 — Enable showLastUpdateTime and showLastUpdateAuthor: - Freshness signals for AI citation and search ranking Task 4 — Noindex deprecated doc versions (v1.0.0, v2.0.0): - Added Disallow rules in robots.txt - Added X-Robots-Tag noindex headers in netlify.toml - Prevents duplicate content from old versions consuming crawl budget Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
The Products > Integration Testing link pointed to the removed server/installation route. Updated to the correct /install path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Docusaurus docs site navigation and SEO/indexing configuration, primarily to fix the Products → Integration Testing navbar link so it points to the correct /install route.
Changes:
- Fix the navbar “Integration Testing” link to route to
install(i.e.,/docs/install). - Update multiple glossary doc frontmatter titles/descriptions (SEO-oriented metadata changes).
- Add noindex/no-crawl handling for deprecated doc versions (
/docs/1.0.0/,/docs/2.0.0/) and enable “last updated” author/time display in docs.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| versioned_docs/version-4.0.0/concepts/reference/glossary/white-box-testing.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/unit-testing.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/regression-testing.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/performance-testing.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/mocks.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/load-testing.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/integration-testing.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/idempotency.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/code-coverage.md | Update frontmatter title/description. |
| versioned_docs/version-4.0.0/concepts/reference/glossary/black-box-testing.md | Update frontmatter title/description. |
| static/robots.txt | Disallow crawling deprecated doc versions. |
| netlify.toml | Add X-Robots-Tag headers to noindex deprecated doc versions. |
| docusaurus.config.js | Fix navbar link to install; enable last updated author/time display. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * Whether to display the author who last updated the doc. | ||
| */ | ||
| showLastUpdateAuthor: false, | ||
| showLastUpdateAuthor: true, | ||
| /** | ||
| * Whether to display the last date the doc was updated. | ||
| */ | ||
| showLastUpdateTime: false, | ||
| showLastUpdateTime: true, |
There was a problem hiding this comment.
This PR changes more than the described navbar fix: it also enables showLastUpdateAuthor/showLastUpdateTime (site-wide UI/behavior change) and includes unrelated SEO/indexing changes in other files. Please update the PR title/description (or split into separate PRs) so reviewers can assess each change with the right context and test plan.
There was a problem hiding this comment.
Updated the PR title and description to cover all changes including the SEO/indexing work and showLastUpdateAuthor/Time (carried from the base branch).
static/robots.txt
Outdated
| Disallow: /docs/1.0.0/ | ||
| Disallow: /docs/2.0.0/ |
There was a problem hiding this comment.
robots.txt is disallowing /docs/1.0.0/ and /docs/2.0.0/ while the PR also adds X-Robots-Tag: noindex headers for those paths. For crawlers that honor robots.txt, the Disallow can prevent them from fetching the pages and seeing the noindex header, which can undermine the de-indexing goal. Consider removing these Disallow rules (or otherwise ensuring crawlers can see the noindex directive) if the intent is to keep the pages accessible but not indexed.
| Disallow: /docs/1.0.0/ | |
| Disallow: /docs/2.0.0/ |
There was a problem hiding this comment.
Fixed — removed the Disallow rules for /docs/1.0.0/ and /docs/2.0.0/ from robots.txt so crawlers can reach the pages and honor the X-Robots-Tag: noindex header for proper de-indexing.
Changed article wrapper margin from my-12 (top+bottom) to mb-12 (bottom only) to eliminate the unnecessary 48px gap at the top of every docs page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
- Zero out docusaurus-mt-lg margin to eliminate gap between navbar and breadcrumbs on every docs page - Fix announcement bar CSS selector (class^= -> class*=) so styles actually apply - Restyle announcement bar with striped light orange background - Update banner text to highlight Keploy v4 and eBPF Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
- Changed h1/h2 color from washed-out black (#111827) to brand dark blue (#00163D), h3/h4 to #0a2a5e - Removed emojis from all 25 h1 headings in version-3.0.0 docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
Added margin-left to footer on doc pages matching the sidebar width at each breakpoint (180/200/260/280px). Resets to 0 on mobile where sidebar is full-width. This prevents the footer from overlapping under the sidebar. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
Disallow blocks crawlers from fetching the pages, preventing them from seeing the X-Robots-Tag noindex header. Removing the Disallow rules lets crawlers reach the pages and honor the noindex directive for proper de-indexing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docusaurus.config.js:1
- "to: "install""
will navigate to/install(site root) rather than/docs/installon a typical Docusaurus setup (and the PR description/test plan explicitly expects/docs/install). Prefer using an absolute docs path (e.g.,/docs/install) or use a Docusaurus docs navbar item (type: "doc", docId: "install") so the link remains correct even ifrouteBasePath` changes.
//@ts-check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/css/custom.css
Outdated
| /* On doc pages, offset footer so it doesn't overlap sidebar */ | ||
| .plugin-docs .theme-layout-footer.footer, | ||
| .docs-wrapper ~ .theme-layout-footer.footer, | ||
| [class*="docsWrapper"] ~ footer, | ||
| .plugin-docs footer.footer { | ||
| margin-left: 260px !important; |
There was a problem hiding this comment.
This unconditional margin-left: 260px !important; rule is declared after the responsive footer rules above (including the mobile reset), so it will override them in the cascade when selectors have similar specificity—preventing the breakpoint-specific margin-left values (and the <=996px reset to 0) from taking effect. Move the base footer offset rule earlier (before the breakpoint overrides), or re-declare the breakpoint-specific footer rules after this block, so mobile and other breakpoints can correctly control the footer alignment.
| /* On doc pages, offset footer so it doesn't overlap sidebar */ | |
| .plugin-docs .theme-layout-footer.footer, | |
| .docs-wrapper ~ .theme-layout-footer.footer, | |
| [class*="docsWrapper"] ~ footer, | |
| .plugin-docs footer.footer { | |
| margin-left: 260px !important; | |
| /* On doc pages, offset footer so it doesn't overlap sidebar on desktop only */ | |
| @media (min-width: 997px) { | |
| .plugin-docs .theme-layout-footer.footer, | |
| .docs-wrapper ~ .theme-layout-footer.footer, | |
| [class*="docsWrapper"] ~ footer, | |
| .plugin-docs footer.footer { | |
| margin-left: 260px !important; | |
| } |
There was a problem hiding this comment.
Good catch — wrapped the base footer offset in @media (min-width: 997px) so it only applies on desktop and doesn't fight with the breakpoint-specific rules. Also removed the now-redundant mobile reset block.
- Fixed navbar link to server/install (not bare install) so the route resolves and the build passes - Ran prettier on all modified files to pass formatting check - Wrapped base footer margin-left in @media (min-width: 997px) per Copilot review so it doesn't override mobile/breakpoint rules Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 31 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* Also reveal copy button when the container or button has keyboard focus */ | ||
| div[class*="codeBlockContainer"]:focus-within button[class*="copyButton"], | ||
| div[class*="codeBlockContainer"] button[class*="copyButton"]:focus-visible { | ||
| opacity: 1 !important; | ||
| transform: translateY(0); | ||
| } | ||
| /* --- Force DM Sans on Docs Pages --- */ | ||
| @import url('https://fonts.googleapis.com/css2?family=DM+Sans:wght@400;700&display=swap'); | ||
| @import url("https://fonts.googleapis.com/css2?family=DM+Sans:wght@400;700&display=swap"); | ||
|
|
There was a problem hiding this comment.
@import rules must appear before any non-@charset style rules. Here the Google Fonts @import comes after regular selectors (lines 1-6), which can cause the import to be ignored by the browser. Move the font import to the very top of the file (or load the font via a <link rel="preload/stylesheet"> in headTags) so DM Sans is reliably applied.
There was a problem hiding this comment.
Fixed — moved the @import for Google Fonts to the very top of custom.css so it precedes all style rules.
src/css/custom.css
Outdated
| .docs-wrapper ~ .theme-layout-footer.footer, | ||
| [class*="docsWrapper"] ~ footer, | ||
| .plugin-docs footer.footer { | ||
| margin-left: 260px !important; |
There was a problem hiding this comment.
The desktop footer offset rule (margin-left: 260px) is declared after the breakpoint-specific footer offsets (e.g., 180px/200px/280px). On widths where both media queries match, this later rule will win in the cascade and effectively disable the breakpoint-specific values. Consider either (a) using a single margin-left: var(--doc-sidebar-width) (since you already set --doc-sidebar-width), or (b) moving this base rule earlier and keeping the more specific breakpoint rules after it.
| margin-left: 260px !important; | |
| margin-left: var(--doc-sidebar-width, 260px) !important; |
There was a problem hiding this comment.
Fixed — replaced all hardcoded margin-left values with var(--doc-sidebar-width, 260px) in a single desktop-scoped rule. The CSS variable is now updated at each breakpoint alongside the sidebar width, so the footer tracks automatically.
| { | ||
| label: "Integration Testing", | ||
| to: "server/installation", | ||
| to: "server/install", | ||
| }, |
There was a problem hiding this comment.
PR description/test plan says the navbar should route to /docs/install, but the actual navbar target is server/install (which will resolve to /server/install under routeBasePath: "/", plus the site baseUrl). To avoid confusion for reviewers, align the description/test plan with the actual route (or adjust this to value if /install is the intended URL).
There was a problem hiding this comment.
Fixed — updated the PR description to say /docs/server/install to match the actual to: "server/install" navbar target.
…desc - Moved @import for Google Fonts to top of custom.css so it precedes all style rules - Replaced hardcoded footer margin-left values with var(--doc-sidebar-width) and update the variable at each breakpoint - Updated PR description to match actual route (server/install) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Operating System | Without Docker | Docker Installation | Prerequisites | | ||
| | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | <img src="https://www.pngplay.com/wp-content/uploads/3/Apple-Logo-Transparent-Images.png" width="15" height="15" alt="MacOS" /> **MacOS** | [Guide](/keploy-explained/mac-linux.md) | [Guide](/server/installation/) | - Docker Desktop version must be 4.25.2 or above <br/> - Ensure that Lima is installed on your machine if you prefer to try without Docker. | | ||
| | <img src="https://upload.wikimedia.org/wikipedia/commons/5/5f/Windows_logo_-_2012.svg" width="15" height="15" alt="Windows" /> **Windows** | [Guide](/keploy-explained/windows-wsl.md) | [Guide](/server/installation/) | - Use [WSL](https://learn.microsoft.com/en-us/windows/wsl/install#install-wsl-command) `wsl --install` <br/> - Windows 10 version 2004 and higher (Build 19041 and higher) or Windows 11 <br/> - Ensure that Docker Desktop version 4.25.2 or above is installed if you are following the Docker installation guide | | ||
| | <img src="https://www.pngplay.com/wp-content/uploads/3/Apple-Logo-Transparent-Images.png" width="15" height="15" alt="MacOS" /> **MacOS** | [Guide](/keploy-explained/mac-linux.md) | [Guide](/server/installation/) | - Docker Desktop version must be 4.25.2 or above <br/> - Ensure that Lima is installed on your machine if you prefer to try without Docker. | | ||
| | <img src="https://upload.wikimedia.org/wikipedia/commons/5/5f/Windows_logo_-_2012.svg" width="15" height="15" alt="Windows" /> **Windows** | [Guide](/keploy-explained/windows-wsl.md) | [Guide](/server/installation/) | - Use [WSL](https://learn.microsoft.com/en-us/windows/wsl/install#install-wsl-command) `wsl --install` <br/> - Windows 10 version 2004 and higher (Build 19041 and higher) or Windows 11 <br/> - Ensure that Docker Desktop version 4.25.2 or above is installed if you are following the Docker installation guide | |
There was a problem hiding this comment.
The Docker Installation links in this table still point to /server/installation/, but in v3 the server installation doc route is /server/install (frontmatter id: install). This link will 404 unless you have explicit redirects—please update the table links to the correct route (and keep trailing slash consistent with trailingSlash: true).
There was a problem hiding this comment.
Fixed — updated both Docker Installation links in the v3 platform-requirements table from /server/installation/ to /server/install/.
| /* Docusaurus specific wrappers */ | ||
| .docusaurus-mt-lg, | ||
| .docs-doc-page, | ||
| [class*="docsWrapper"] { | ||
| max-width: 100% !important; | ||
| width: 100% !important; | ||
| margin-top: 0 !important; | ||
| } |
There was a problem hiding this comment.
This rule overrides .docusaurus-mt-lg globally. Since that class is a general Docusaurus spacing utility (not docs-specific), this can unintentionally remove top spacing on non-doc pages that use the same class. Consider scoping the margin override to docs pages only (e.g., body[data-docs-root] .docusaurus-mt-lg or .plugin-docs .docusaurus-mt-lg).
There was a problem hiding this comment.
Fixed — scoped the margin-top: 0 override to .plugin-docs .docusaurus-mt-lg so it only applies on doc pages. Non-doc pages retain the default Docusaurus spacing.
- Scoped margin-top:0 override to .plugin-docs .docusaurus-mt-lg so non-doc pages keep their default spacing - Updated Docker Installation links in v3 platform-requirements.md from /server/installation/ to /server/install/ Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
src/css/custom.css:2824
- The
@media (max-width: 1200px)block sets--doc-sidebar-widthand forces.theme-doc-sidebar-containerto 200px. Because this media query also matches mobile widths (<996px) and appears after the dedicated mobile sidebar rules, it can override the intended mobilewidth: 100%sidebar behavior. Consider scoping this breakpoint to desktop only (e.g.,(min-width: 997px) and (max-width: 1200px)) or otherwise ensuring the mobile@media (max-width: 996px)rules win in the cascade.
/* Tablet breakpoint */
@media (max-width: 1200px) {
[class*="tableOfContents"] {
min-width: 140px;
max-width: 180px;
padding-left: 0.25rem;
padding-right: 0.5rem;
margin-right: 0;
}
.col.col--3 {
--ifm-col-width: 180px !important;
flex: 0 0 180px !important;
max-width: 180px !important;
padding-right: 0.75rem !important;
padding-left: 0.25rem !important;
}
:root {
--doc-sidebar-width: 200px !important;
}
.theme-doc-sidebar-container {
width: 200px !important;
min-width: 200px !important;
}
src/css/custom.css:2862
- Similar to the 1200px breakpoint, this
@media (max-width: 1100px)rule forces.theme-doc-sidebar-containerto 180px and updates--doc-sidebar-width. Since it also matches mobile widths and comes after the@media (max-width: 996px)mobile sidebar rules, it can unintentionally override the mobile layout. Restrict this breakpoint to desktop widths (e.g., addmin-width: 997px) or move mobile overrides after these blocks.
/* Medium screens */
@media (max-width: 1100px) {
[class*="tableOfContents"] {
min-width: 120px;
max-width: 160px;
}
.col.col--3 {
--ifm-col-width: 160px !important;
flex: 0 0 160px !important;
max-width: 160px !important;
padding-right: 0.5rem !important;
}
:root {
--doc-sidebar-width: 180px !important;
}
.theme-doc-sidebar-container {
width: 180px !important;
min-width: 180px !important;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docusaurus.config.js
Outdated
| id: "announcementBar_1", // Increment on change | ||
| content: `⭐️ If you like Keploy, give it a star on <a target="_blank" rel="noopener noreferrer" href="https://github.com/keploy/keploy">GitHub</a> and follow us on <a target="_blank" rel="noopener noreferrer" href="https://twitter.com/keployio">Twitter</a> ❤️ `, | ||
| id: "announcementBar_2", // Increment on change | ||
| content: `🚀 Keploy v4 is here — zero-code API testing powered by eBPF. <a target="_blank" rel="noopener noreferrer" href="https://github.com/keploy/keploy">Star us on GitHub (10K+)</a> and join the community on <a target="_blank" rel="noopener noreferrer" href="https://twitter.com/keployio">Twitter</a>!`, |
There was a problem hiding this comment.
keep the messaging like previous ones.
There was a problem hiding this comment.
Done — reverted the announcement bar text back to the original messaging.
- Reverted announcement bar content to original messaging per review - Added min-width: 997px to 1200px and 1100px breakpoints so they don't override mobile sidebar/footer rules Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/css/custom.css
Outdated
| /* Announcement bar - striped orange styling */ | ||
| div[class*="announcementBar"] { | ||
| background: repeating-linear-gradient( | ||
| 135deg, | ||
| rgba(255, 145, 77, 0.15), | ||
| rgba(255, 145, 77, 0.15) 10px, | ||
| rgba(255, 145, 77, 0.05) 10px, | ||
| rgba(255, 145, 77, 0.05) 20px | ||
| ) !important; | ||
| font-weight: 600; | ||
| font-size: 0.875rem; | ||
| padding: 0.5rem 0; | ||
| border: none; | ||
| border: none !important; | ||
| border-bottom: 1px solid rgba(255, 145, 77, 0.2) !important; | ||
| color: #00163d !important; | ||
| } |
There was a problem hiding this comment.
The selector div[class*="announcementBar"] is very broad and will also match nested Announcement Bar elements whose class names include the same substring (e.g., content/close wrappers). That can unintentionally apply padding/borders/background to inner nodes and break layout. Consider narrowing the selector to the top-level Announcement Bar container only (for example by adding a more specific class token match or an attribute like [role="banner"], and/or explicitly excluding *Content*/close elements).
There was a problem hiding this comment.
Fixed — narrowed the selector to div[class*="announcementBar"]:not([class*="Content"]):not([class*="Close"]) so it only targets the top-level container.
Added :not([class*="Content"]):not([class*="Close"]) to prevent styles from leaking into nested announcement bar elements. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| div[class*="announcementBar"] a { | ||
| color: #ff914d !important; | ||
| text-decoration: underline; | ||
| text-underline-offset: 2px; | ||
| font-weight: 700; |
There was a problem hiding this comment.
Announcement bar links use color: #ff914d on a very light orange/near-white striped background. That combination is likely below WCAG contrast requirements, which can make the GitHub/Twitter links hard to read for some users. Consider using a darker link color (e.g., a darker brand orange) and/or only using orange on hover while keeping the default link text closer to the main bar text color.
There was a problem hiding this comment.
Fixed — darkened link color from #ff914d to #c45a1a for WCAG contrast compliance on the light orange striped background. Hover is now #a0460f.
src/css/custom.css
Outdated
| @@ -1,11 +1,12 @@ | |||
| /* --- Force DM Sans on Docs Pages --- */ | |||
| @import url("https://fonts.googleapis.com/css2?family=DM+Sans:wght@400;700&display=swap"); | |||
There was a problem hiding this comment.
Loading Google Fonts via CSS @import is render-blocking and can noticeably delay first paint on docs pages. Prefer adding a <link rel="preconnect">/<link rel="stylesheet"> in headTags (or self-hosting the font) and remove redundant imports (the repo also imports DM Sans in src/theme/DocItem/styles.module.css).
| @import url("https://fonts.googleapis.com/css2?family=DM+Sans:wght@400;700&display=swap"); |
There was a problem hiding this comment.
Fixed — moved DM Sans loading to headTags in docusaurus.config.js with preconnect hints. Removed both CSS @import statements from custom.css and DocItem/styles.module.css.
- Darkened announcement bar link color from #ff914d to #c45a1a for WCAG contrast compliance on light orange background - Moved DM Sans font loading from CSS @import to headTags in docusaurus.config.js (non-render-blocking) - Removed duplicate @import from DocItem/styles.module.css Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docusaurus.config.js
Outdated
| // Google Fonts - DM Sans (non-render-blocking) | ||
| { | ||
| tagName: "link", | ||
| attributes: { | ||
| rel: "preconnect", | ||
| href: "https://fonts.googleapis.com", | ||
| }, | ||
| }, | ||
| { | ||
| tagName: "link", | ||
| attributes: { | ||
| rel: "preconnect", | ||
| href: "https://fonts.gstatic.com", | ||
| crossorigin: "anonymous", | ||
| }, | ||
| }, | ||
| { | ||
| tagName: "link", | ||
| attributes: { | ||
| rel: "stylesheet", | ||
| href: "https://fonts.googleapis.com/css2?family=DM+Sans:wght@400;700&display=swap", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
The new DM Sans loading block is labeled as “non-render-blocking”, but a <link rel="stylesheet"> Google Fonts stylesheet is still render-blocking (just less problematic than CSS @import). If the intent is truly non-render-blocking, consider using a preload+onload swap (with noscript fallback) or self-hosting the font; otherwise, please adjust the comment so it doesn’t mislead future readers about the performance characteristics.
There was a problem hiding this comment.
Fixed — updated the comment to accurately say "loaded via headTags instead of CSS @import" without the misleading "non-render-blocking" claim.
Changed "non-render-blocking" to accurately describe that DM Sans is loaded via headTags instead of CSS @import. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --ifm-color-primary-lightest: #ffceb1; | ||
| --ifm-code-font-size: 95%; | ||
| --doc-sidebar-width: 275px !important; | ||
| --doc-sidebar-width: 260px !important; | ||
| --ifm-link-hover-decoration: none; |
There was a problem hiding this comment.
--doc-sidebar-width is now used for footer alignment, but the sidebar width itself is still hard-coded elsewhere in this file (e.g., .theme-doc-sidebar-container { width: 260px; } and breakpoint overrides). That duplication can drift over time and break the footer alignment again. Consider using width/min-width: var(--doc-sidebar-width) for the sidebar container so the CSS variable remains the single source of truth across breakpoints.
There was a problem hiding this comment.
Fixed — replaced all hardcoded width/min-width values on .theme-doc-sidebar-container with var(--doc-sidebar-width) so the CSS variable is the single source of truth across the base rule and all breakpoints.
Replaced hardcoded px values in .theme-doc-sidebar-container with var(--doc-sidebar-width) so the CSS variable is the single source of truth for both sidebar and footer alignment across breakpoints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
server/installationtoserver/installdocusaurus-mt-lgmargin and changed article wrapper frommy-12tomb-12class^=->class*=) so styles apply; added striped light orange background with catchier copymargin-left: var(--doc-sidebar-width)on desktop to stay aligned with content area across all breakpointsTest plan
Generated with Claude Code