fix(site24x7): resolve status and tags/labels not sent via webhook#6210
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix(site24x7): resolve status and tags/labels not sent via webhook#6210DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
Fix two bugs in the Site24x7 provider: - keephq#6195: Alert status was not being set. When Site24x7 sends UP status, the alert should resolve (AlertStatus.RESOLVED), but the provider only set severity, not status. Added STATUS_MAP and set status field. - keephq#6196: Tags and labels from the webhook payload were being ignored. Now extracts TAGS and LABELS fields from the webhook and includes them in the AlertDto. Closes keephq#6195 Closes keephq#6196
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:M
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix two bugs in the Site24x7 provider where webhook alerts weren't properly handling resolve status or tags/labels.
Why
Closes #6195 — Alert status was never being set. When Site24x7 sends a webhook with
STATUS=UP(monitor recovered), the alert should resolve, but the provider only mapped status to severity, not to the AlertDto status field. Alerts stayed permanently in "Firing" state.Closes #6196 — Tags and labels configured on Site24x7 monitors were being sent in the webhook payload (as
TAGSandLABELSfields) but the provider's_format_alertmethod was ignoring them entirely.How
STATUS_MAP— Maps Site24x7 statuses to Keep'sAlertStatus:DOWN/TROUBLE/CRITICAL→FIRING,UP→RESOLVEDstatusfield inAlertDto— Previously onlyseveritywas setTAGSandLABELSfrom webhook payload — Parses comma-separated strings into listssource=["site24x7"]— Was missing from the AlertDtoTesting
STATUS=UPproducesAlertStatus.RESOLVEDSTATUS=DOWNproducesAlertStatus.FIRING