Skip to content

fix: strip HTML tags from note values in alert table columns #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DragonBot00 wants to merge 1 commit into from
Closed

fix: strip HTML tags from note values in alert table columns #6183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion keep-ui/widgets/alerts-table/lib/alert-table-utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,15 @@ export const getCellClassName = (

const columnHelper = createColumnHelper<AlertDto>();

/**
* Strips HTML tags from a string, returning plain text.
* Used to display note values (saved via a rich-text editor) as plain text
* in alert table columns.
*/
const stripHtml = (html: string): string => {
return html.replace(/<[^>]*>/g, " ").replace(/\s{2,}/g, " ").trim();
};

interface GenerateAlertTableColsArg {
additionalColsToGenerate?: string[];
isCheckboxDisplayed?: boolean;
Expand Down Expand Up @@ -344,6 +353,13 @@ export const useAlertTableCols = (
}

if (value) {
// Strip HTML tags from note values — notes are saved by a rich-text
// editor (Quill) which wraps content in HTML tags like <p>...</p>.
// Table columns should display plain text only.
const displayValue =
context.column.id === "note" && typeof value === "string"
? stripHtml(value)
: value.toString();
return (
<div
className={clsx(
Expand All @@ -353,7 +369,7 @@ export const useAlertTableCols = (
(rowStyle === "default" ? "line-clamp-1" : "line-clamp-3")
)}
>
{value.toString()}
{displayValue}
</div>
);
}
Expand Down
Loading