fix: strip HTML tags from note values in alert table columns#6183
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix: strip HTML tags from note values in alert table columns#6183DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
dosubot
bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5283
Problem
When a user adds a note to an alert using the rich-text editor (Quill), the note content is stored with HTML markup (e.g., <p>My note text
). When theote\ field is displayed in the alert table columns, the raw HTML string was rendered as plain text, causing the user to see <p>My note text\ instead of \My note text.
Fix
Added a \stripHtml\ utility function in \keep-ui/widgets/alerts-table/lib/alert-table-utils.tsx\ that removes HTML tags using a regex replacement. When the generic column cell renderer encounters the
ote\ column, it now passes the value through \stripHtml\ before rendering — displaying clean, readable plain text in the table.
Changes
ote\ column cell rendering.