Skip to content

fix: use correct auth scopes for DELETE and POST routes in incidents.py #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DragonBot00 wants to merge 1 commit into from
Closed

fix: use correct auth scopes for DELETE and POST routes in incidents.py #6178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions keep/api/routes/incidents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import logging
import logging
from typing import List, Optional
from uuid import UUID

Expand Down Expand Up @@ -215,7 +215,7 @@ def get_all_incidents(
def fetch_inicident_facet_options(
facet_options_query: FacetOptionsQueryDto,
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["read:alert"])
IdentityManagerFactory.get_auth_verifier(["read:incidents"])
),
) -> dict:
tenant_id = authenticated_entity.tenant_id
Expand Down Expand Up @@ -427,7 +427,7 @@ def update_incident(
def bulk_delete_incidents(
incident_ids: List[UUID] = Body(..., embed=True),
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["write:incident"])
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
),
pusher_client: Pusher | None = Depends(get_pusher_client),
session: Session = Depends(get_session),
Expand All @@ -445,7 +445,7 @@ def bulk_delete_incidents(
def delete_incident(
incident_id: UUID,
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["write:incident"])
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
),
pusher_client: Pusher | None = Depends(get_pusher_client),
session: Session = Depends(get_session),
Expand Down Expand Up @@ -718,7 +718,7 @@ def delete_alerts_from_incident(
incident_id: UUID,
fingerprints: List[str],
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["write:incident"])
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
),
session=Depends(get_session),
pusher_client: Pusher | None = Depends(get_pusher_client),
Expand Down Expand Up @@ -1155,3 +1155,4 @@ async def unenrich_incident(
)

return Response(status_code=202)

Loading