fix: use correct auth scopes for DELETE and POST routes in incidents.py#6178
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix: use correct auth scopes for DELETE and POST routes in incidents.py#6178DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect auth scopes in
keep/api/routes/incidents.py.Following the permissions convention (
read,write,delete,update), DELETE endpoints should requiredelete:*scope, notwrite:*. Usingwrite:incidenton DELETE routes means a role that can create/update incidents can also delete them — making it impossible to grant modify-only access without also granting delete access.Closes #5363
Changes
Fixed
delete:incidentscope on DELETE routes:DELETE /bulk— bulk delete incidentsDELETE /{incident_id}— delete single incidentDELETE /{incident_id}/alerts— remove alerts from incidentFixed
read:incidentsscope on POST query route:POST /facets/options— this is a read query (POST with body for filtering), should useread:incidentsnotread:alertAlso unified scope naming:
read:incidents(plural) was used alongsideread:incident(singular) — the facets/options route already usedread:alertwhich is semantically wrong for an incident query endpoint.Before / After
DELETE /bulkwrite:incidentdelete:incidentDELETE /{incident_id}write:incidentdelete:incidentDELETE /{incident_id}/alertswrite:incidentdelete:incidentPOST /facets/optionsread:alertread:incidents