build(deps): fix build/tests on JRuby 10.0.3.0 #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack of Ruby 3.4 compatibility Wihout this, the normal tests work, however the integration tests fail before being invoked during `Execution default-package of goal org.jruby.maven:gem-maven-plugin:3.0.6:package` which seem to rely on maven-tools to parse the integration test POM before invoking it. Seemed the best place to declare the dependency was here, since this is where jbundler and implicitly maven-tools are defined, although declaring it in the Mavenfile also seems to work. LoadError: cannot load such file -- bigdecimal require at org/jruby/RubyKernel.java:1193 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:139 <main> at /Users/chad/.m2/repository/org/jruby/maven/ruby-tools/3.0.6/ruby-tools-3.0.6.jar!/axiom/types.rb:3 require at org/jruby/RubyKernel.java:1193 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:139 <main> at /Users/chad/.m2/repository/org/jruby/maven/ruby-tools/3.0.6/ruby-tools-3.0.6.jar!/axiom-types.rb:3 require at org/jruby/RubyKernel.java:1193 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:139 <main> at /Users/chad/.m2/repository/org/jruby/maven/ruby-tools/3.0.6/ruby-tools-3.0.6.jar!/virtus.rb:245 require at org/jruby/RubyKernel.java:1193 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:139 <main> at /Users/chad/.m2/repository/org/jruby/maven/ruby-tools/3.0.6/ruby-tools-3.0.6.jar!/maven/tools/model.rb:1 require at org/jruby/RubyKernel.java:1193 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:139 <main> at /Users/chad/.m2/repository/org/jruby/maven/ruby-tools/3.0.6/ruby-tools-3.0.6.jar!/maven/tools/pom.rb:22 require at org/jruby/RubyKernel.java:1193 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:139 <main> at -e:1
chadlwilson
changed the title
chadlwilson
added a commit
to chadlwilson/maven-tools
that referenced
this pull request
Feb 4, 2026
Added bigdecimal as a runtime dependency due to virtus EOL, and transitive dependency requirement. See jruby/warbler#607 for addition info.
chadlwilson
added a commit
to chadlwilson/maven-tools
that referenced
this pull request
Feb 4, 2026
Added bigdecimal as a runtime dependency due to virtus EOL, and transitive dependency requirement. See jruby/warbler#607 for addition info.
chadlwilson
added a commit
to chadlwilson/maven-tools
that referenced
this pull request
Feb 4, 2026
Added bigdecimal and ostruct as runtime dependencies due to virtus EOL, and transitive dependency requirement. See jruby/warbler#607 for additional info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around jbundler/maven-tools > virtus > axiom-types lack of Ruby 3.4 compatibility
Without this, the normal tests work, however the integration tests fail before being invoked during
Execution default-package of goal org.jruby.maven:gem-maven-plugin:3.0.6:packagewhich seem to rely on maven-tools to parse the integration test POM before usingmaven-invoker-pluginto invoke it. Seemed the best place to declare the dependency was here, since this is where jbundler and implicitly maven-tools are defined, although declaring it in the Mavenfile also seems to work.