Correct usage of maven-tools under JRuby 10.0.3+ and Ruby 4.0#42
Merged
headius merged 9 commits intojruby:masterfrom Feb 4, 2026
Merged
Correct usage of maven-tools under JRuby 10.0.3+ and Ruby 4.0#42headius merged 9 commits intojruby:masterfrom
headius merged 9 commits intojruby:masterfrom
Conversation
chadlwilson
force-pushed
the
patch-1
branch
2 times, most recently
from
95f5b33 to
f1f30c5
Compare
Added bigdecimal and ostruct as runtime dependencies due to virtus EOL, and transitive dependency requirement. See jruby/warbler#607 for additional info.
The previous versions don't work properly on modern Maven 3. Since Maven 3.9 is the only non EOL version, and Maven 3.9 is also EOL 9 months ago, this should not be a problem. Right now users need to override these from Mavenfile to get things to work and avoid warnings, which is a pain.
ostruct is no longer a default gem; and it doesn't seem necessary when a normal struct will do
This is EOL, and broken on modern Rubies due to bad syntax, and needs replacement with something else.
chadlwilson
changed the title
headius
approved these changes
Feb 4, 2026
Member
|
Good cleanup and updates! Let me know if there's more coming or if we should push an updated gem. |
Contributor
Author
|
I think we can probably push it, already went a bit too far while trying to get this sorted and gradually untangle in my head how these bits are all related 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added bigdecimal and ostruct as runtime dependencies due to virtus EOL, and its (also EOL) transitive
axiom-typesrequirement.See jruby/warbler#607 for some additional info.
Also did some tidy-up
FWIW, I note that the sonatype fork (before migration here) at master...sonatype:maven-tools:master seems to have a
dry-structmigration fromvirtus.