Skip to content

RTECO-1368 - Fix metrics collection for agent detection and interactive context fields#3518

Merged
fluxxBot merged 1 commit into
masterfrom
RTECO-1368-Fix-AgentMetric
May 28, 2026
Merged

RTECO-1368 - Fix metrics collection for agent detection and interactive context fields#3518
fluxxBot merged 1 commit into
masterfrom
RTECO-1368-Fix-AgentMetric

Conversation

@fluxxBot
Copy link
Copy Markdown
Contributor

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

RTECO-1368: Fix dropped agent metric labels (is_agent, agent, is_interactive)

Problem

PR #1555 (RTECO-1017) added agent/CI context fields to MetricsData and
populated them in metrics_collector.go, but the labels were silently dropped
on the way to the visibility wire payload. Prod logs (jfcli_commands_count)
still don't show is_agent, agent, or is_interactive.

Root cause

Two broken links in the chain:

  1. commandsCountLabels struct in commands_count_metric.go had no fields
    for the new agent labels, so they could never be serialized.
  2. reportUsageToVisibilitySystem in command.go didn't copy the new
    fields from collected MetricsData into visibility.MetricsData.

Depends on:

  1. core - RTECO-1368 - Fix metrics collection for agent detection and interactive context fields jfrog-cli-core#1566

@fluxxBot fluxxBot added the bug Something isn't working label May 27, 2026
@fluxxBot fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from d26d257 to fb3bd71 Compare May 27, 2026 19:32
@fluxxBot fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from fb3bd71 to 7e7c81a Compare May 27, 2026 19:41
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label May 27, 2026
@fluxxBot fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from 7e7c81a to a25d8ce Compare May 27, 2026 20:54
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 27, 2026
@fluxxBot fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from a25d8ce to a39c3bc Compare May 27, 2026 21:02
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 27, 2026
@fluxxBot fluxxBot requested a review from bhanurp May 28, 2026 05:34
@fluxxBot fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from a39c3bc to ab1fc6c Compare May 28, 2026 06:13
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 28, 2026
@fluxxBot fluxxBot enabled auto-merge (squash) May 28, 2026 06:14
@fluxxBot fluxxBot merged commit 2f3acd3 into master May 28, 2026
95 of 99 checks passed
@fluxxBot fluxxBot deleted the RTECO-1368-Fix-AgentMetric branch May 28, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants