Skip to content

RTECO-1368 - Fix metrics collection for agent detection and interactive context fields#1566

Merged
fluxxBot merged 1 commit into
masterfrom
RTECO-1368-Fix-AgentMetric
May 28, 2026
Merged

RTECO-1368 - Fix metrics collection for agent detection and interactive context fields#1566
fluxxBot merged 1 commit into
masterfrom
RTECO-1368-Fix-AgentMetric

Conversation

@fluxxBot
Copy link
Copy Markdown
Contributor

@fluxxBot fluxxBot commented May 27, 2026

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the master branch.
  • I used gofmt for formatting the code before submitting the pull request.

RTECO-1368: Fix dropped agent metric labels (is_agent, agent, is_interactive)

Problem

PR #1555 (RTECO-1017) added agent/CI context fields to MetricsData and
populated them in metrics_collector.go, but the labels were silently dropped
on the way to the visibility wire payload. Prod logs (jfcli_commands_count)
still don't show is_agent, agent, or is_interactive.

Root cause

Two broken links in the chain:

  1. commandsCountLabels struct in commands_count_metric.go had no fields
    for the new agent labels, so they could never be serialized.
  2. reportUsageToVisibilitySystem in command.go didn't copy the new
    fields from collected MetricsData into visibility.MetricsData.

Depends on:

  1. cli - RTECO-1368 - Fix metrics collection for agent detection and interactive context fields jfrog-cli#3518

@fluxxBot fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from 25c77c0 to e894f31 Compare May 27, 2026 20:41
Comment thread common/commands/execution_context.go
@fluxxBot fluxxBot merged commit b41c87a into master May 28, 2026
10 of 11 checks passed
@fluxxBot fluxxBot deleted the RTECO-1368-Fix-AgentMetric branch May 28, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants